| Message ID | 20190424075352.22828-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [-next] crypto: atmel - remove set but not used variable 'alg_name' | expand |
On 24/04/2019 at 09:53, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey': > drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not used [-Wunused-but-set-variable] > > It is not used any more since > commit 52ea3cd2917b ("crypto: atmel - Forbid 2-key 3DES in FIPS mode") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Looks good to me: Reviewed-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > drivers/crypto/atmel-tdes.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c > index 12492d9..fa76620 100644 > --- a/drivers/crypto/atmel-tdes.c > +++ b/drivers/crypto/atmel-tdes.c > @@ -800,12 +800,9 @@ static int atmel_tdes_setkey(struct crypto_ablkcipher *tfm, const u8 *key, > unsigned int keylen) > { > struct atmel_tdes_ctx *ctx = crypto_ablkcipher_ctx(tfm); > - const char *alg_name; > u32 flags; > int err; > > - alg_name = crypto_tfm_alg_name(crypto_ablkcipher_tfm(tfm)); > - > flags = crypto_ablkcipher_get_flags(tfm); > err = __des3_verify_key(&flags, key); > if (unlikely(err)) { >
On 04/24/2019 10:53 AM, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey': > drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not used [-Wunused-but-set-variable] > > It is not used any more since > commit 52ea3cd2917b ("crypto: atmel - Forbid 2-key 3DES in FIPS mode") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> > --- > drivers/crypto/atmel-tdes.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c > index 12492d9..fa76620 100644 > --- a/drivers/crypto/atmel-tdes.c > +++ b/drivers/crypto/atmel-tdes.c > @@ -800,12 +800,9 @@ static int atmel_tdes_setkey(struct crypto_ablkcipher *tfm, const u8 *key, > unsigned int keylen) > { > struct atmel_tdes_ctx *ctx = crypto_ablkcipher_ctx(tfm); > - const char *alg_name; > u32 flags; > int err; > > - alg_name = crypto_tfm_alg_name(crypto_ablkcipher_tfm(tfm)); > - > flags = crypto_ablkcipher_get_flags(tfm); > err = __des3_verify_key(&flags, key); > if (unlikely(err)) { >
On Wed, Apr 24, 2019 at 03:53:52PM +0800, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey': > drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not used [-Wunused-but-set-variable] > > It is not used any more since > commit 52ea3cd2917b ("crypto: atmel - Forbid 2-key 3DES in FIPS mode") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/crypto/atmel-tdes.c | 3 --- > 1 file changed, 3 deletions(-) Patch applied. Thanks.
diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c index 12492d9..fa76620 100644 --- a/drivers/crypto/atmel-tdes.c +++ b/drivers/crypto/atmel-tdes.c @@ -800,12 +800,9 @@ static int atmel_tdes_setkey(struct crypto_ablkcipher *tfm, const u8 *key, unsigned int keylen) { struct atmel_tdes_ctx *ctx = crypto_ablkcipher_ctx(tfm); - const char *alg_name; u32 flags; int err; - alg_name = crypto_tfm_alg_name(crypto_ablkcipher_tfm(tfm)); - flags = crypto_ablkcipher_get_flags(tfm); err = __des3_verify_key(&flags, key); if (unlikely(err)) {