| Message ID | 20190909052952.GA32131@embeddedor (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: talitos - fix missing break in switch statement | expand |
Le 09/09/2019 à 07:29, Gustavo A. R. Silva a écrit : > Add missing break statement in order to prevent the code from falling > through to case CRYPTO_ALG_TYPE_AHASH. > > Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface") > Cc: stable@vger.kernel.org > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr> > --- > drivers/crypto/talitos.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c > index c9d686a0e805..4818ae427098 100644 > --- a/drivers/crypto/talitos.c > +++ b/drivers/crypto/talitos.c > @@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev) > break; > case CRYPTO_ALG_TYPE_AEAD: > crypto_unregister_aead(&t_alg->algt.alg.aead); > + break; > case CRYPTO_ALG_TYPE_AHASH: > crypto_unregister_ahash(&t_alg->algt.alg.hash); > break; >
On Mon, Sep 09, 2019 at 12:29:52AM -0500, Gustavo A. R. Silva wrote: > Add missing break statement in order to prevent the code from falling > through to case CRYPTO_ALG_TYPE_AHASH. > > Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface") > Cc: stable@vger.kernel.org > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/crypto/talitos.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks.
Hi all, Friendly ping: Who can take this? Thanks -- Gustavo On 9/10/19 01:06, Christophe Leroy wrote: > > > Le 09/09/2019 à 07:29, Gustavo A. R. Silva a écrit : >> Add missing break statement in order to prevent the code from falling >> through to case CRYPTO_ALG_TYPE_AHASH. >> >> Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface") >> Cc: stable@vger.kernel.org >> Reported-by: kbuild test robot <lkp@intel.com> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr> > >> --- >> drivers/crypto/talitos.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c >> index c9d686a0e805..4818ae427098 100644 >> --- a/drivers/crypto/talitos.c >> +++ b/drivers/crypto/talitos.c >> @@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev) >> break; >> case CRYPTO_ALG_TYPE_AEAD: >> crypto_unregister_aead(&t_alg->algt.alg.aead); >> + break; >> case CRYPTO_ALG_TYPE_AHASH: >> crypto_unregister_ahash(&t_alg->algt.alg.hash); >> break; >>
diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index c9d686a0e805..4818ae427098 100644 --- a/drivers/crypto/talitos.c +++ b/drivers/crypto/talitos.c @@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev) break; case CRYPTO_ALG_TYPE_AEAD: crypto_unregister_aead(&t_alg->algt.alg.aead); + break; case CRYPTO_ALG_TYPE_AHASH: crypto_unregister_ahash(&t_alg->algt.alg.hash); break;
Add missing break statement in order to prevent the code from falling through to case CRYPTO_ALG_TYPE_AHASH. Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface") Cc: stable@vger.kernel.org Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/crypto/talitos.c | 1 + 1 file changed, 1 insertion(+)