| Message ID | 20200324084821.29944-17-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | x86, crypto: remove always-defined CONFIG_AS_* and cosolidate Kconfig/Makefiles | expand |
On Tue, Mar 24, 2020 at 05:48:21PM +0900, Masahiro Yamada wrote: > poly1305-x86_64-cryptogams.S is a generated file, so it should be > cleaned up by 'make clean'. > > Assigning it to the variable 'targets' teaches Kbuild that it is a > generated file. However, this line is not evaluated while cleaning > because scripts/Makefile.clean does not include include/config/auto.conf. > > Removing the ifneq-conditional, so this file is correctly cleaned up. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > arch/x86/crypto/Makefile | 2 -- > 1 file changed, 2 deletions(-) Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/arch/x86/crypto/Makefile b/arch/x86/crypto/Makefile index 928aad453c72..a31de0c6ccde 100644 --- a/arch/x86/crypto/Makefile +++ b/arch/x86/crypto/Makefile @@ -83,9 +83,7 @@ crct10dif-pclmul-y := crct10dif-pcl-asm_64.o crct10dif-pclmul_glue.o obj-$(CONFIG_CRYPTO_POLY1305_X86_64) += poly1305-x86_64.o poly1305-x86_64-y := poly1305-x86_64-cryptogams.o poly1305_glue.o -ifneq ($(CONFIG_CRYPTO_POLY1305_X86_64),) targets += poly1305-x86_64-cryptogams.S -endif obj-$(CONFIG_CRYPTO_NHPOLY1305_SSE2) += nhpoly1305-sse2.o nhpoly1305-sse2-y := nh-sse2-x86_64.o nhpoly1305-sse2-glue.o
poly1305-x86_64-cryptogams.S is a generated file, so it should be cleaned up by 'make clean'. Assigning it to the variable 'targets' teaches Kbuild that it is a generated file. However, this line is not evaluated while cleaning because scripts/Makefile.clean does not include include/config/auto.conf. Removing the ifneq-conditional, so this file is correctly cleaned up. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- arch/x86/crypto/Makefile | 2 -- 1 file changed, 2 deletions(-)