| Message ID | 20200724165027.GA18496@embeddedor (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [next] crypto: sa2ul - Fix inconsistent IS_ERR and PTR_ERR | expand |
On Fri, Jul 24, 2020 at 11:50:27AM -0500, Gustavo A. R. Silva wrote: > Fix inconsistent IS_ERR and PTR_ERR in sa_dma_init(). The proper pointer > to be passed as argument to PTR_ERR() is dd->dma_tx. > > This bug was detected with the help of Coccinelle. > > Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/crypto/sa2ul.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.
On 7/31/20 08:32, Herbert Xu wrote: > On Fri, Jul 24, 2020 at 11:50:27AM -0500, Gustavo A. R. Silva wrote: >> Fix inconsistent IS_ERR and PTR_ERR in sa_dma_init(). The proper pointer >> to be passed as argument to PTR_ERR() is dd->dma_tx. >> >> This bug was detected with the help of Coccinelle. >> >> Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- >> drivers/crypto/sa2ul.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Patch applied. Thanks. > Awesome. :) Thanks -- Gustavo
diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index ebcdffcdb686..5bc099052bd2 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -2259,7 +2259,7 @@ static int sa_dma_init(struct sa_crypto_data *dd) dd->dma_tx = dma_request_chan(dd->dev, "tx"); if (IS_ERR(dd->dma_tx)) { - if (PTR_ERR(dd->dma_rx1) != -EPROBE_DEFER) + if (PTR_ERR(dd->dma_tx) != -EPROBE_DEFER) dev_err(dd->dev, "Unable to request tx DMA channel\n"); ret = PTR_ERR(dd->dma_tx); goto err_dma_tx;
Fix inconsistent IS_ERR and PTR_ERR in sa_dma_init(). The proper pointer to be passed as argument to PTR_ERR() is dd->dma_tx. This bug was detected with the help of Coccinelle. Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/crypto/sa2ul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)