| Message ID | 20210617035129.4948-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [-next] crypto: sl3516 - Fix build warning without CONFIG_PM | expand |
Le Thu, Jun 17, 2021 at 11:51:29AM +0800, YueHaibing a écrit : > drivers/crypto/gemini/sl3516-ce-core.c:345:12: > warning: ‘sl3516_ce_pm_resume’ defined but not used [-Wunused-function] > static int sl3516_ce_pm_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~~ > > Use #ifdef macro to guard this. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/crypto/gemini/sl3516-ce-core.c | 2 ++ > 1 file changed, 2 insertions(+) > Hello Thanks for the report, but I am sorry and need to NAK this patch. The driver needs PM, without it, clock and resets are never set. The correct fix is to add "depends on PM". Regards
On 2021/6/17 21:00, LABBE Corentin wrote: > Le Thu, Jun 17, 2021 at 11:51:29AM +0800, YueHaibing a écrit : >> drivers/crypto/gemini/sl3516-ce-core.c:345:12: >> warning: ‘sl3516_ce_pm_resume’ defined but not used [-Wunused-function] >> static int sl3516_ce_pm_resume(struct device *dev) >> ^~~~~~~~~~~~~~~~~~~ >> >> Use #ifdef macro to guard this. >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> drivers/crypto/gemini/sl3516-ce-core.c | 2 ++ >> 1 file changed, 2 insertions(+) >> > > Hello > > Thanks for the report, but I am sorry and need to NAK this patch. > > The driver needs PM, without it, clock and resets are never set. > The correct fix is to add "depends on PM". Ok, v2 on the way, thanks. > > Regards > . >
diff --git a/drivers/crypto/gemini/sl3516-ce-core.c b/drivers/crypto/gemini/sl3516-ce-core.c index da6cd529a6c0..00bfc5e19818 100644 --- a/drivers/crypto/gemini/sl3516-ce-core.c +++ b/drivers/crypto/gemini/sl3516-ce-core.c @@ -320,6 +320,7 @@ static void sl3516_ce_unregister_algs(struct sl3516_ce_dev *ce) } } +#ifdef CONFIG_PM static void sl3516_ce_start(struct sl3516_ce_dev *ce) { ce->ctx = 0; @@ -365,6 +366,7 @@ static int sl3516_ce_pm_resume(struct device *dev) sl3516_ce_pm_suspend(dev); return err; } +#endif static const struct dev_pm_ops sl3516_ce_pm_ops = { SET_RUNTIME_PM_OPS(sl3516_ce_pm_suspend, sl3516_ce_pm_resume, NULL)
drivers/crypto/gemini/sl3516-ce-core.c:345:12: warning: ‘sl3516_ce_pm_resume’ defined but not used [-Wunused-function] static int sl3516_ce_pm_resume(struct device *dev) ^~~~~~~~~~~~~~~~~~~ Use #ifdef macro to guard this. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/crypto/gemini/sl3516-ce-core.c | 2 ++ 1 file changed, 2 insertions(+)