| Message ID | 20240312183618.1211745-2-stefanb@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | Add support for NIST P521 to ecdsa | expand |
On Tue Mar 12, 2024 at 8:36 PM EET, Stefan Berger wrote: > From: Stefan Berger <stefanb@linux.ibm.com> > > Replace hard-coded numbers with ECC_CURVE_NIST_P192/256/384_DIGITS where > possible. > > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> > --- > crypto/ecc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/crypto/ecc.c b/crypto/ecc.c > index f53fb4d6af99..415a2f4e7291 100644 > --- a/crypto/ecc.c > +++ b/crypto/ecc.c > @@ -689,7 +689,7 @@ static void vli_mmod_barrett(u64 *result, u64 *product, const u64 *mod, > static void vli_mmod_fast_192(u64 *result, const u64 *product, > const u64 *curve_prime, u64 *tmp) > { > - const unsigned int ndigits = 3; > + const unsigned int ndigits = ECC_CURVE_NIST_P192_DIGITS; > int carry; > > vli_set(result, product, ndigits); > @@ -717,7 +717,7 @@ static void vli_mmod_fast_256(u64 *result, const u64 *product, > const u64 *curve_prime, u64 *tmp) > { > int carry; > - const unsigned int ndigits = 4; > + const unsigned int ndigits = ECC_CURVE_NIST_P256_DIGITS; > > /* t */ > vli_set(result, product, ndigits); > @@ -800,7 +800,7 @@ static void vli_mmod_fast_384(u64 *result, const u64 *product, > const u64 *curve_prime, u64 *tmp) > { > int carry; > - const unsigned int ndigits = 6; > + const unsigned int ndigits = ECC_CURVE_NIST_P384_DIGITS; > > /* t */ > vli_set(result, product, ndigits); > @@ -932,13 +932,13 @@ static bool vli_mmod_fast(u64 *result, u64 *product, > } > > switch (ndigits) { > - case 3: > + case ECC_CURVE_NIST_P192_DIGITS: > vli_mmod_fast_192(result, product, curve_prime, tmp); > break; > - case 4: > + case ECC_CURVE_NIST_P256_DIGITS: > vli_mmod_fast_256(result, product, curve_prime, tmp); > break; > - case 6: > + case ECC_CURVE_NIST_P384_DIGITS: > vli_mmod_fast_384(result, product, curve_prime, tmp); > break; > default: Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> BR, Jarkko
diff --git a/crypto/ecc.c b/crypto/ecc.c index f53fb4d6af99..415a2f4e7291 100644 --- a/crypto/ecc.c +++ b/crypto/ecc.c @@ -689,7 +689,7 @@ static void vli_mmod_barrett(u64 *result, u64 *product, const u64 *mod, static void vli_mmod_fast_192(u64 *result, const u64 *product, const u64 *curve_prime, u64 *tmp) { - const unsigned int ndigits = 3; + const unsigned int ndigits = ECC_CURVE_NIST_P192_DIGITS; int carry; vli_set(result, product, ndigits); @@ -717,7 +717,7 @@ static void vli_mmod_fast_256(u64 *result, const u64 *product, const u64 *curve_prime, u64 *tmp) { int carry; - const unsigned int ndigits = 4; + const unsigned int ndigits = ECC_CURVE_NIST_P256_DIGITS; /* t */ vli_set(result, product, ndigits); @@ -800,7 +800,7 @@ static void vli_mmod_fast_384(u64 *result, const u64 *product, const u64 *curve_prime, u64 *tmp) { int carry; - const unsigned int ndigits = 6; + const unsigned int ndigits = ECC_CURVE_NIST_P384_DIGITS; /* t */ vli_set(result, product, ndigits); @@ -932,13 +932,13 @@ static bool vli_mmod_fast(u64 *result, u64 *product, } switch (ndigits) { - case 3: + case ECC_CURVE_NIST_P192_DIGITS: vli_mmod_fast_192(result, product, curve_prime, tmp); break; - case 4: + case ECC_CURVE_NIST_P256_DIGITS: vli_mmod_fast_256(result, product, curve_prime, tmp); break; - case 6: + case ECC_CURVE_NIST_P384_DIGITS: vli_mmod_fast_384(result, product, curve_prime, tmp); break; default: