diff mbox series

[v2] dt-bindings: crypto: ice: Document QCS9100 inline crypto engine

Message ID 20240709-documnet_qcs9100_crypto_engine_compatible-v2-1-59bd16b1a99c@quicinc.com (mailing list archive)
State Changes Requested
Delegated to: Herbert Xu
Headers show
Series [v2] dt-bindings: crypto: ice: Document QCS9100 inline crypto engine | expand

Commit Message

Tengfei Fan July 9, 2024, 1:08 p.m. UTC 
Document the compatible used for the inline crypto engine found on
QCS9100.

QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
platform use non-SCMI resource. In the future, the SA8775p platform will
move to use SCMI resources and it will have new sa8775p-related device
tree. Consequently, introduce "qcom,qcs9100-inline-crypto-engine" to
describe non-SCMI based crypto engine.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
Introduce support for the QCS9100 SoC device tree (DTSI) and the
QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
While the QCS9100 platform is still in the early design stage, the
QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
mounts the QCS9100 SoC instead of the SA8775p SoC.

The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
all the compatible strings will be updated from "SA8775p" to "QCS9100".
The QCS9100 device tree patches will be pushed after all the device tree
bindings and device driver patches are reviewed.

The final dtsi will like:
https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
 
The detailed cover letter reference:
https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/

Co-developed-by: Maria Yu <quic_aiquny@quicinc.com>
Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>
---
Changes in v2:
   - Split huge patch series into different patch series according to
     subsytems
   - Update patch commit message

prevous disscussion here:
[1] v1: https://lore.kernel.org/linux-arm-msm/1b32168b-7d1c-4b18-b4f3-a4979232b515@quicinc.com
---
 Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
change-id: 20240709-documnet_qcs9100_crypto_engine_compatible-e5de2d56bca9

Best regards,

Comments

Krzysztof Kozlowski July 10, 2024, 10:16 a.m. UTC | #1 
On 09/07/2024 15:08, Tengfei Fan wrote:
> Document the compatible used for the inline crypto engine found on
> QCS9100.
> 
> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> platform use non-SCMI resource. In the future, the SA8775p platform will
> move to use SCMI resources and it will have new sa8775p-related device
> tree. Consequently, introduce "qcom,qcs9100-inline-crypto-engine" to
> describe non-SCMI based crypto engine.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
> Introduce support for the QCS9100 SoC device tree (DTSI) and the
> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
> While the QCS9100 platform is still in the early design stage, the
> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
> mounts the QCS9100 SoC instead of the SA8775p SoC.
> 
> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
> all the compatible strings will be updated from "SA8775p" to "QCS9100".
> The QCS9100 device tree patches will be pushed after all the device tree
> bindings and device driver patches are reviewed.
> 
> The final dtsi will like:
> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
>  
> The detailed cover letter reference:
> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
> 
> Co-developed-by: Maria Yu <quic_aiquny@quicinc.com>
> Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>

This looks messy - wrongly placed, not in correct DCO order. Some tools
will just ignore it, some might produce wrong result.

Best regards,
Krzysztof
Tengfei Fan July 10, 2024, 10:23 a.m. UTC | #2 
On 7/10/2024 6:16 PM, Krzysztof Kozlowski wrote:
> On 09/07/2024 15:08, Tengfei Fan wrote:
>> Document the compatible used for the inline crypto engine found on
>> QCS9100.
>>
>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>> platform use non-SCMI resource. In the future, the SA8775p platform will
>> move to use SCMI resources and it will have new sa8775p-related device
>> tree. Consequently, introduce "qcom,qcs9100-inline-crypto-engine" to
>> describe non-SCMI based crypto engine.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>> Introduce support for the QCS9100 SoC device tree (DTSI) and the
>> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
>> While the QCS9100 platform is still in the early design stage, the
>> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
>> mounts the QCS9100 SoC instead of the SA8775p SoC.
>>
>> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
>> all the compatible strings will be updated from "SA8775p" to "QCS9100".
>> The QCS9100 device tree patches will be pushed after all the device tree
>> bindings and device driver patches are reviewed.
>>
>> The final dtsi will like:
>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
>>   
>> The detailed cover letter reference:
>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>
>> Co-developed-by: Maria Yu <quic_aiquny@quicinc.com>
>> Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>
> 
> This looks messy - wrongly placed, not in correct DCO order. Some tools
> will just ignore it, some might produce wrong result.
> 
> Best regards,
> Krzysztof
> 

Thanks Krzysztof!

I will fix the messy information in all the QCS9100 related patch series 
in the next.
Tengfei Fan July 29, 2024, 10:26 a.m. UTC | #3 
On 7/10/2024 6:23 PM, Tengfei Fan wrote:
> 
> 
> On 7/10/2024 6:16 PM, Krzysztof Kozlowski wrote:
>> On 09/07/2024 15:08, Tengfei Fan wrote:
>>> Document the compatible used for the inline crypto engine found on
>>> QCS9100.
>>>
>>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>>> platform use non-SCMI resource. In the future, the SA8775p platform will
>>> move to use SCMI resources and it will have new sa8775p-related device
>>> tree. Consequently, introduce "qcom,qcs9100-inline-crypto-engine" to
>>> describe non-SCMI based crypto engine.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>> Introduce support for the QCS9100 SoC device tree (DTSI) and the
>>> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
>>> While the QCS9100 platform is still in the early design stage, the
>>> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
>>> mounts the QCS9100 SoC instead of the SA8775p SoC.
>>>
>>> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
>>> all the compatible strings will be updated from "SA8775p" to "QCS9100".
>>> The QCS9100 device tree patches will be pushed after all the device tree
>>> bindings and device driver patches are reviewed.
>>>
>>> The final dtsi will like:
>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
>>> The detailed cover letter reference:
>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>>
>>> Co-developed-by: Maria Yu <quic_aiquny@quicinc.com>
>>> Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>
>>
>> This looks messy - wrongly placed, not in correct DCO order. Some tools
>> will just ignore it, some might produce wrong result.
>>
>> Best regards,
>> Krzysztof
>>
> 
> Thanks Krzysztof!
> 
> I will fix the messy information in all the QCS9100 related patch series 
> in the next.
> 

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore the current patche here.
Thank you for your input.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
index 0304f074cf08..ad0944e05025 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
@@ -13,6 +13,7 @@  properties:
   compatible:
     items:
       - enum:
+          - qcom,qcs9100-inline-crypto-engine
           - qcom,sa8775p-inline-crypto-engine
           - qcom,sc7180-inline-crypto-engine
           - qcom,sc7280-inline-crypto-engine