| Message ID | 20240718-md-powerpc-arch-powerpc-crypto-v1-1-b23a1989248e@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: ppc/curve25519 - add missing MODULE_DESCRIPTION() macro | expand |
On Thu, Jul 18, 2024 at 06:14:18PM -0700, Jeff Johnson wrote: > Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the > description is missing"), a module without a MODULE_DESCRIPTION() will > result in a warning with make W=1. The following warning is being > observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m: > > WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/crypto/curve25519-ppc64le.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks.
On 8/2/2024 6:15 AM, Herbert Xu wrote: > On Thu, Jul 18, 2024 at 06:14:18PM -0700, Jeff Johnson wrote: >> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the >> description is missing"), a module without a MODULE_DESCRIPTION() will >> result in a warning with make W=1. The following warning is being >> observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m: >> >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/crypto/curve25519-ppc64le.o >> >> Add the missing invocation of the MODULE_DESCRIPTION() macro. >> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> >> --- >> arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 + >> 1 file changed, 1 insertion(+) > > Patch applied. Thanks. Great, that was the last of my MODULE_DESCRIPTION patches!!! There are a few more instances of the warning that Arnd has patches for, covering issues that appear in randconfigs that I didn't test. /jeff
On Fri, Aug 02, 2024 at 07:27:09AM -0700, Jeff Johnson wrote: > On 8/2/2024 6:15 AM, Herbert Xu wrote: > > On Thu, Jul 18, 2024 at 06:14:18PM -0700, Jeff Johnson wrote: > >> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the > >> description is missing"), a module without a MODULE_DESCRIPTION() will > >> result in a warning with make W=1. The following warning is being > >> observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m: > >> > >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/crypto/curve25519-ppc64le.o > >> > >> Add the missing invocation of the MODULE_DESCRIPTION() macro. > >> > >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > >> --- > >> arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > Patch applied. Thanks. > > Great, that was the last of my MODULE_DESCRIPTION patches!!! > Horray! Congratulations. :) regards, dan carpenter
On Fri, Aug 2, 2024, at 16:27, Jeff Johnson wrote: > On 8/2/2024 6:15 AM, Herbert Xu wrote: >> On Thu, Jul 18, 2024 at 06:14:18PM -0700, Jeff Johnson wrote: >>> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the >>> description is missing"), a module without a MODULE_DESCRIPTION() will >>> result in a warning with make W=1. The following warning is being >>> observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m: >>> >>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/crypto/curve25519-ppc64le.o >>> >>> Add the missing invocation of the MODULE_DESCRIPTION() macro. >>> >>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> >>> --- >>> arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 + >>> 1 file changed, 1 insertion(+) >> >> Patch applied. Thanks. > > Great, that was the last of my MODULE_DESCRIPTION patches!!! > > There are a few more instances of the warning that Arnd has patches for, > covering issues that appear in randconfigs that I didn't test. Are all of your patches in linux-next now, or is there a another git tree that has them all? I can send the ones I have left, but I want to avoid duplication. Arnd
On 8/2/2024 8:16 AM, Arnd Bergmann wrote: > On Fri, Aug 2, 2024, at 16:27, Jeff Johnson wrote: >> On 8/2/2024 6:15 AM, Herbert Xu wrote: >>> On Thu, Jul 18, 2024 at 06:14:18PM -0700, Jeff Johnson wrote: >>>> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the >>>> description is missing"), a module without a MODULE_DESCRIPTION() will >>>> result in a warning with make W=1. The following warning is being >>>> observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m: >>>> >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/crypto/curve25519-ppc64le.o >>>> >>>> Add the missing invocation of the MODULE_DESCRIPTION() macro. >>>> >>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> >>>> --- >>>> arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 + >>>> 1 file changed, 1 insertion(+) >>> >>> Patch applied. Thanks. >> >> Great, that was the last of my MODULE_DESCRIPTION patches!!! >> >> There are a few more instances of the warning that Arnd has patches for, >> covering issues that appear in randconfigs that I didn't test. > > Are all of your patches in linux-next now, or is there a another > git tree that has them all? > > I can send the ones I have left, but I want to avoid duplication. > > Arnd When this one lands they'll all be in linux-next
diff --git a/arch/powerpc/crypto/curve25519-ppc64le-core.c b/arch/powerpc/crypto/curve25519-ppc64le-core.c index 4e3e44ea4484..f7810be0b292 100644 --- a/arch/powerpc/crypto/curve25519-ppc64le-core.c +++ b/arch/powerpc/crypto/curve25519-ppc64le-core.c @@ -295,5 +295,6 @@ module_exit(curve25519_mod_exit); MODULE_ALIAS_CRYPTO("curve25519"); MODULE_ALIAS_CRYPTO("curve25519-ppc64le"); +MODULE_DESCRIPTION("PPC64le Curve25519 scalar multiplication with 51 bits limbs"); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Danny Tsen <dtsen@us.ibm.com>");
Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing"), a module without a MODULE_DESCRIPTION() will result in a warning with make W=1. The following warning is being observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m: WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/crypto/curve25519-ppc64le.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: df1e9791998a92fe9f1e7d3f031b34daaad39e2f change-id: 20240718-md-powerpc-arch-powerpc-crypto-2c96382d0eaf