| Message ID | 5648D40B.8020002@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Herbert Xu |
| Headers | show |
On Sun, Nov 15, 2015 at 07:50:51PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 15 Nov 2015 18:28:39 +0100 > > The dma_pool_destroy() function was called twice with a null pointer > if a "npe_error" was reported. > > This implementation detail could be improved by the introduction > of another jump label. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/crypto/ixp4xx_crypto.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c > index e52496a..efe0eca 100644 > --- a/drivers/crypto/ixp4xx_crypto.c > +++ b/drivers/crypto/ixp4xx_crypto.c > @@ -509,9 +509,11 @@ static int init_ixp_crypto(struct device *dev) > npe_error: > printk(KERN_ERR "%s not responding\n", npe_name(npe_c)); > ret = -EIO; > + goto release_npe; > err: > dma_pool_destroy(ctx_pool); > dma_pool_destroy(buffer_pool); > +release_npe: > npe_release(npe_c); > return ret; I think this patch is making the code worse so I'm not applying it.
diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c index e52496a..efe0eca 100644 --- a/drivers/crypto/ixp4xx_crypto.c +++ b/drivers/crypto/ixp4xx_crypto.c @@ -509,9 +509,11 @@ static int init_ixp_crypto(struct device *dev) npe_error: printk(KERN_ERR "%s not responding\n", npe_name(npe_c)); ret = -EIO; + goto release_npe; err: dma_pool_destroy(ctx_pool); dma_pool_destroy(buffer_pool); +release_npe: npe_release(npe_c); return ret; }