diff mbox series

[5/8] Replace memset() with memzero_explicit()

Message ID CACXcFmmZUggw8Ze7eoXhcvOtf8cWXJoS51MNwVmMGiK7ggCeOw@mail.gmail.com (mailing list archive)
State Changes Requested
Delegated to: Herbert Xu
Headers show
Series memset() in crypto code | expand

Commit Message

Sandy Harris Nov. 16, 2021, 11:34 a.m. UTC 
Replace memset(address,0,bytes) which may be optimised
away with memzero_explicit(address,bytes) which resists
such optimisation

---
 crypto/shash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

            shash->update(desc, data + unaligned_len, len - unaligned_len);
@@ -156,7 +156,7 @@ static int shash_final_unaligned(struct shash_desc
*desc, u8 *out)
     memcpy(out, buf, ds);

 out:
-    memset(buf, 0, ds);
+    memzero_explicit(buf, ds);
     return err;
 }
diff mbox series

Patch

diff --git a/crypto/shash.c b/crypto/shash.c
index 0a0a50cb694f..f07d06f5da71 100644
--- a/crypto/shash.c
+++ b/crypto/shash.c
@@ -112,7 +112,7 @@  static int shash_update_unaligned(struct
shash_desc *desc, const u8 *data,

     memcpy(buf, data, unaligned_len);
     err = shash->update(desc, buf, unaligned_len);
-    memset(buf, 0, unaligned_len);
+    memzero_explicit(buf, unaligned_len);

     return err ?: