| Message ID | YIkTi9a3nnL50wMq@kroah.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | Revert "crypto: cavium/nitrox - add an error message to explain the failure of pci_request_mem_regions" | expand |
On Wed, Apr 28, 2021 at 09:49:31AM +0200, Greg Kroah-Hartman wrote: > This reverts commit 9fcddaf2e28d779cb946d23838ba6d50f299aa80 as it was > submitted under a fake name and we can not knowingly accept anonymous > contributions to the repository. > > This commit was part of a submission "test" to the Linux kernel > community by some "researchers" at umn.edu. As outlined at: > https://www-users.cs.umn.edu/%7Ekjlu/papers/full-disclosure.pdf > it was done so as an attempt to submit a known-buggy patch to see if it > could get by our review. However, the submission turned out to actually > be correct, and not have a bug in it as the author did not understand > how the PCI driver model works at all, and so the submission was > accepted. > > As this change is of useless consequence, there is no loss of > functionality in reverting it. > > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Cc: linux-crypto@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/crypto/cavium/nitrox/nitrox_main.c | 1 - > 1 file changed, 1 deletion(-) > > Herbert, I will be taking this as part of my larger "revert buggy patch > submissions from umn.edu" tree, so no need for you to take this in your > tree at this point in time, I just wanted to give you a heads up as to > what is happening here. Acked-by: Herbert Xu <herbert@gondor.apana.org.au> Thanks,
On Thu, Apr 29, 2021 at 08:18:34AM +0800, Herbert Xu wrote: > On Wed, Apr 28, 2021 at 09:49:31AM +0200, Greg Kroah-Hartman wrote: > > This reverts commit 9fcddaf2e28d779cb946d23838ba6d50f299aa80 as it was > > submitted under a fake name and we can not knowingly accept anonymous > > contributions to the repository. > > > > This commit was part of a submission "test" to the Linux kernel > > community by some "researchers" at umn.edu. As outlined at: > > https://www-users.cs.umn.edu/%7Ekjlu/papers/full-disclosure.pdf > > it was done so as an attempt to submit a known-buggy patch to see if it > > could get by our review. However, the submission turned out to actually > > be correct, and not have a bug in it as the author did not understand > > how the PCI driver model works at all, and so the submission was > > accepted. > > > > As this change is of useless consequence, there is no loss of > > functionality in reverting it. > > > > Cc: Herbert Xu <herbert@gondor.apana.org.au> > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > Cc: linux-crypto@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > drivers/crypto/cavium/nitrox/nitrox_main.c | 1 - > > 1 file changed, 1 deletion(-) > > > > Herbert, I will be taking this as part of my larger "revert buggy patch > > submissions from umn.edu" tree, so no need for you to take this in your > > tree at this point in time, I just wanted to give you a heads up as to > > what is happening here. > > Acked-by: Herbert Xu <herbert@gondor.apana.org.au> Wonderful, thanks for the review. greg k-h
diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c index facc8e6bc580..d385daf2c71c 100644 --- a/drivers/crypto/cavium/nitrox/nitrox_main.c +++ b/drivers/crypto/cavium/nitrox/nitrox_main.c @@ -442,7 +442,6 @@ static int nitrox_probe(struct pci_dev *pdev, err = pci_request_mem_regions(pdev, nitrox_driver_name); if (err) { pci_disable_device(pdev); - dev_err(&pdev->dev, "Failed to request mem regions!\n"); return err; } pci_set_master(pdev);
This reverts commit 9fcddaf2e28d779cb946d23838ba6d50f299aa80 as it was submitted under a fake name and we can not knowingly accept anonymous contributions to the repository. This commit was part of a submission "test" to the Linux kernel community by some "researchers" at umn.edu. As outlined at: https://www-users.cs.umn.edu/%7Ekjlu/papers/full-disclosure.pdf it was done so as an attempt to submit a known-buggy patch to see if it could get by our review. However, the submission turned out to actually be correct, and not have a bug in it as the author did not understand how the PCI driver model works at all, and so the submission was accepted. As this change is of useless consequence, there is no loss of functionality in reverting it. Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: linux-crypto@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/crypto/cavium/nitrox/nitrox_main.c | 1 - 1 file changed, 1 deletion(-) Herbert, I will be taking this as part of my larger "revert buggy patch submissions from umn.edu" tree, so no need for you to take this in your tree at this point in time, I just wanted to give you a heads up as to what is happening here.