From patchwork Tue Feb 28 18:28:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan McDowell X-Patchwork-Id: 13155115 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69B42C64ED6 for ; Tue, 28 Feb 2023 18:28:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229437AbjB1S2w (ORCPT ); Tue, 28 Feb 2023 13:28:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbjB1S2v (ORCPT ); Tue, 28 Feb 2023 13:28:51 -0500 Received: from the.earth.li (the.earth.li [IPv6:2a00:1098:86:4d:c0ff:ee:15:900d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64B603345C; Tue, 28 Feb 2023 10:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=earth.li; s=the; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5XDgmrCVldCZcKRfq8ly88XN9tFbmvTHx2oZvsD+P54=; b=rjt+/6zTNh9QtloPA0iKD7d45W vVp82Gm11hA67RpvQE2UVkGRTXDwoAHA6cbrgifvD91xlU2MhTI4yBv5amxhmtFNyyjMwd/QHOuRj rkTNF/pQMdrp9FOnQTsmTPOu2i0LvKif/eIcnESFvKwf9uTjFrDhuWw+1/BnM5CV6+5D55EJnCX09 NkmtwJESPbnQtfGZWgxdLf0jh0jHmRA5L9ODYsOCYaiKXKF3aG7DpSz605b/yAjmQpk03N+9TIk16 0EIdmcZqoJvBfCJv1ZlJ2fyi/pNzo6/4xP0Q276ssYRA8xIMJscdyd4erTytcSs+UKzV0hrVOVJ+C MXg37iGA==; Received: from [2001:4d48:ad59:1403::17ca] (helo=earth.li) by the.earth.li with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pX4iS-008oS5-9l; Tue, 28 Feb 2023 18:28:44 +0000 Date: Tue, 28 Feb 2023 18:28:40 +0000 From: Jonathan McDowell To: Antoine Tenart , Herbert Xu , "David S. Miller" Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] crypto: inside-secure: Raise firmware load failure message to error Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org At the moment if there is no firmware available for the safexcel driver it will fail to load with a cryptic: crypto-safexcel f2800000.crypto: TRC init: 15360d,80a (48r,256h) crypto-safexcel f2800000.crypto: HW init failed (-2) Raise the logging level of the firmware load failure to err rather than dbg so that it's obvious what the reason for the HW init failure is. Signed-off-by: Jonathan McDowell Reviewed-by: Antoine Tenart --- drivers/crypto/inside-secure/safexcel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c index 6858753af6b3..5e10ab24be3b 100644 --- a/drivers/crypto/inside-secure/safexcel.c +++ b/drivers/crypto/inside-secure/safexcel.c @@ -474,7 +474,7 @@ static int eip197_load_firmwares(struct safexcel_crypto_priv *priv) goto retry_fw; } - dev_dbg(priv->dev, "Firmware load failed.\n"); + dev_err(priv->dev, "Firmware load failed.\n"); return ret; }