| Message ID | cca43549-7715-44ba-a1c0-61dd027ed3b5@stanley.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: qat - (qat_4xxx) fix off by one in uof_get_name() | expand |
On Sat, Sep 28, 2024 at 01:05:08PM +0300, Dan Carpenter wrote: > The fw_objs[] array has "num_objs" elements so the > needs to be >= to > prevent an out of bounds read. > > Fixes: 10484c647af6 ("crypto: qat - refactor fw config logic for 4xxx") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
On Sat, Sep 28, 2024 at 01:05:08PM +0300, Dan Carpenter wrote: > The fw_objs[] array has "num_objs" elements so the > needs to be >= to > prevent an out of bounds read. > > Fixes: 10484c647af6 ("crypto: qat - refactor fw config logic for 4xxx") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c index 9fd7ec53b9f3..bbd92c017c28 100644 --- a/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c +++ b/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c @@ -334,7 +334,7 @@ static const char *uof_get_name(struct adf_accel_dev *accel_dev, u32 obj_num, else id = -EINVAL; - if (id < 0 || id > num_objs) + if (id < 0 || id >= num_objs) return NULL; return fw_objs[id];
The fw_objs[] array has "num_objs" elements so the > needs to be >= to prevent an out of bounds read. Fixes: 10484c647af6 ("crypto: qat - refactor fw config logic for 4xxx") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)