From patchwork Thu Jan 28 08:46:05 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rajashekhara, Sudhakar" X-Patchwork-Id: 75570 Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o0S9Q4jN015177 for ; Thu, 28 Jan 2010 09:26:40 GMT Received: from dlep36.itg.ti.com ([157.170.170.91]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id o0S8nchJ019011 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 28 Jan 2010 02:49:38 -0600 Received: from linux.omap.com (localhost [127.0.0.1]) by dlep36.itg.ti.com (8.13.8/8.13.8) with ESMTP id o0S8nbxL008890; Thu, 28 Jan 2010 02:49:37 -0600 (CST) Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id EABD080627; Thu, 28 Jan 2010 02:49:36 -0600 (CST) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp53.itg.ti.com (dflp53.itg.ti.com [128.247.5.6]) by linux.omap.com (Postfix) with ESMTP id 8A89F80626 for ; Thu, 28 Jan 2010 02:49:28 -0600 (CST) Received: from tidmzi-ftp.india.ext.ti.com (localhost [127.0.0.1]) by dflp53.itg.ti.com (8.13.8/8.13.8) with SMTP id o0S8nPGn005249; Thu, 28 Jan 2010 02:49:26 -0600 (CST) Received: from symphonyindia.ti.com (symphony-ftp [192.168.247.11]) by tidmzi-ftp.india.ext.ti.com (Postfix) with SMTP id A4FE93886B; Thu, 28 Jan 2010 14:16:05 +0530 (IST) Received: from symx0096290 (symx0096290.tigoc.com [192.168.247.120]) by symphonyindia.ti.com (8.13.1/8.12.10) with ESMTP id o0S8UI9Z026026; Thu, 28 Jan 2010 14:00:25 +0530 From: "Sudhakar Rajashekhara" To: "'Kevin Hilman'" References: <1264549293-25556-1-git-send-email-khilman@deeprootsystems.com> <1264549293-25556-2-git-send-email-khilman@deeprootsystems.com> <026601ca9f54$17a18110$46e48330$@raj@ti.com> <87k4v3y53z.fsf@deeprootsystems.com> In-Reply-To: <87k4v3y53z.fsf@deeprootsystems.com> Subject: RE: [PATCH 1/6] i2c: davinci: Fix smbus Oops with AIC33 usage Date: Thu, 28 Jan 2010 14:16:05 +0530 Message-ID: <02ee01ca9ff6$53cf0d90$fb6d28b0$@raj@ti.com> MIME-Version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AcqfXWpwAMGduEcVTPyOGLNLke7vRAAl+o9Q Content-Language: en-us Cc: "'Alexander Vasiliev'" , davinci-linux-open-source@linux.davincidsp.com, "'Dirk Behme'" , "'Ben Dooks'" , linux-i2c@vger.kernel.org X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: davinci-linux-open-source-bounces@linux.davincidsp.com Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com X-Greylist: Delayed for 00:34:28 by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Thu, 28 Jan 2010 09:26:40 +0000 (UTC) diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c index 35f9daa..8526bce 100644 --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers/i2c/busses/i2c-davinci.c @@ -308,6 +308,9 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop) dev->terminate = 0; + /* write the data into mode register */ + davinci_i2c_write_reg(dev, DAVINCI_I2C_MDR_REG, flag); + /* First byte should be set here, not after interrupt, * because transmit-data-ready interrupt can come before * NACK-interrupt during sending of previous message and @@ -317,9 +320,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop) dev->buf_len--; } - /* write the data into mode register */ - davinci_i2c_write_reg(dev, DAVINCI_I2C_MDR_REG, flag); - r = wait_for_completion_interruptible_timeout(&dev->cmd_complete, dev->adapter.timeout); if (r == 0) {