From patchwork Sat Sep 1 01:02:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 1394721 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by patchwork1.kernel.org (Postfix) with ESMTP id B104A3FDFB for ; Sat, 1 Sep 2012 00:57:03 +0000 (UTC) Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id q810tMtY031785; Fri, 31 Aug 2012 19:55:22 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id q810tMeg009255; Fri, 31 Aug 2012 19:55:22 -0500 Received: from dlelxv23.itg.ti.com (172.17.1.198) by dfle73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.1.323.3; Fri, 31 Aug 2012 19:55:22 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlelxv23.itg.ti.com (8.13.8/8.13.8) with ESMTP id q810tLAx011354; Fri, 31 Aug 2012 19:55:21 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 8430580627; Fri, 31 Aug 2012 19:55:21 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp53.itg.ti.com (dflp53.itg.ti.com [128.247.5.6]) by linux.omap.com (Postfix) with ESMTP id 8783580626 for ; Fri, 31 Aug 2012 19:55:19 -0500 (CDT) Received: from red.ext.ti.com (red.ext.ti.com [192.94.93.37]) by dflp53.itg.ti.com (8.13.8/8.13.8) with ESMTP id q810tJAx002290 for ; Fri, 31 Aug 2012 19:55:19 -0500 (CDT) Received: from psmtp.com (na3sys009amx238.postini.com [74.125.149.122]) by red.ext.ti.com (8.13.7/8.13.7) with SMTP id q810tGAO022855 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 31 Aug 2012 19:55:16 -0500 Received: from merlin.infradead.org ([205.233.59.134]) (using TLSv1) by na3sys009amx238.postini.com ([74.125.148.10]) with SMTP; Fri, 31 Aug 2012 19:55:16 CDT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T7bzV-0005Jj-4I; Sat, 01 Sep 2012 00:55:13 +0000 Received: from 0127ahost2.starwoodbroadband.com ([12.105.246.2] helo=[10.10.3.238]) by canuck.infradead.org with esmtpsa (Exim 4.76 #1 (Red Hat Linux)) id 1T7bzU-0007yV-DY; Sat, 01 Sep 2012 00:55:12 +0000 Message-ID: <1346461349.2806.4.camel@vkoul-mobl4> Subject: Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API From: Vinod Koul To: Sekhar Nori Date: Sat, 1 Sep 2012 06:32:29 +0530 In-Reply-To: <1346432577.15463.16.camel@vkoul-mobl4> References: <1345684176-21472-1-git-send-email-mporter@ti.com> <1345684176-21472-4-git-send-email-mporter@ti.com> <503F75C0.1050507@ti.com> <20120830144307.GA26737@beef> <5040E00A.3080600@ti.com> <1346430709.15463.15.camel@vkoul-mobl4> <5040E6C7.6030106@ti.com> <1346432577.15463.16.camel@vkoul-mobl4> Organization: X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-pstn-neptune: 0/0/0.00/0 X-pstn-levels: (S:99.90000/99.90000 CV:99.9000 FC:95.5390 LC:95.5390 R:95.9108 P:95.9108 M:97.0282 C:98.6951 ) X-pstn-dkim: 0 skipped:not-enabled X-pstn-settings: 2 (0.5000:0.5000) s cv gt3 gt2 gt1 r p m c X-pstn-addresses: from [82/3] CC: Matt Porter , Linux DaVinci Kernel List , , Linux MMC List , Linux Kernel Mailing List , , Linux SPI Devel List , , Linux ARM Kernel List X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com On Fri, 2012-08-31 at 22:32 +0530, Vinod Koul wrote: > On Fri, 2012-08-31 at 22:01 +0530, Sekhar Nori wrote: > > >> Yes, this was the problem. Since the SPI driver now depends on > > >> CONFIG_TI_EDMA for basic operation may be select CONFIG_TI_EDMA in > > >> Kconfig if SPI is enabled? That should do until the fallback to PIO > > is > > >> implemented. > > > Then this should be enabled for SPI. Care to send a patch > > > > By 'this' you mean the Kconfig select? Then there should be no need of > > a > > new patch for this. It can be part of this patch itself, no? > Either way is okay for me. And am in good mood :) Applied all with this as well >From b5f14330590118e6a0659255476c0f24ab681e05 Mon Sep 17 00:00:00 2001 From: Vinod Koul Date: Sat, 1 Sep 2012 06:29:22 +0530 Subject: [PATCH] spi: davici - make davinci select edma Reported-by: Sekhar Nori Signed-off-by: Vinod Koul --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 5f84b55..b9fb9a1 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -134,6 +134,7 @@ config SPI_DAVINCI tristate "Texas Instruments DaVinci/DA8x/OMAP-L/AM1x SoC SPI controller" depends on ARCH_DAVINCI select SPI_BITBANG + select TI_EDMA help SPI master controller for DaVinci/DA8x/OMAP-L/AM1x SPI modules.