| Message ID | 1359097268-22779-2-git-send-email-prabhakar.lad@ti.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi Prahakar, On 01/25/2013 08:01 AM, Prabhakar Lad wrote: > From: Manjunath Hadli<manjunath.hadli@ti.com> > > A lot of SOCs including Texas Instruments Davinci family mainly use > video decoders as input devices. Here the initial subdevice node > from where the input really comes is this decoder, for which support > is needed as part of the Media Controller infrastructure. This patch > adds an additional flag to include the decoders along with others, > such as the sensor and lens. > > Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com> > Signed-off-by: Lad, Prabhakar<prabhakar.lad@ti.com> > --- > include/uapi/linux/media.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index 0ef8833..fa44ed9 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -56,6 +56,7 @@ struct media_device_info { > #define MEDIA_ENT_T_V4L2_SUBDEV_SENSOR (MEDIA_ENT_T_V4L2_SUBDEV + 1) > #define MEDIA_ENT_T_V4L2_SUBDEV_FLASH (MEDIA_ENT_T_V4L2_SUBDEV + 2) > #define MEDIA_ENT_T_V4L2_SUBDEV_LENS (MEDIA_ENT_T_V4L2_SUBDEV + 3) > +#define MEDIA_ENT_T_V4L2_SUBDEV_DECODER (MEDIA_ENT_T_V4L2_SUBDEV + 4) Such a new entity type needs to be documented in the media DocBook [1]. It probably also deserves a comment here, as DECODER isn't that obvious like the other already existing entity types. I heard people referring to a device that encodes analog (composite) video signal into its digital representation as an ENCODER. :) [1] http://hverkuil.home.xs4all.nl/spec/media.html#media-ioc-enum-entities -- Regards, Sylwester
Hi Sylwester, On Sat, Jan 26, 2013 at 1:24 AM, Sylwester Nawrocki <sylvester.nawrocki@gmail.com> wrote: > Hi Prahakar, > > > On 01/25/2013 08:01 AM, Prabhakar Lad wrote: >> >> From: Manjunath Hadli<manjunath.hadli@ti.com> >> >> A lot of SOCs including Texas Instruments Davinci family mainly use >> video decoders as input devices. Here the initial subdevice node >> from where the input really comes is this decoder, for which support >> is needed as part of the Media Controller infrastructure. This patch >> adds an additional flag to include the decoders along with others, >> such as the sensor and lens. >> >> Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com> >> Signed-off-by: Lad, Prabhakar<prabhakar.lad@ti.com> >> --- >> include/uapi/linux/media.h | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h >> index 0ef8833..fa44ed9 100644 >> --- a/include/uapi/linux/media.h >> +++ b/include/uapi/linux/media.h >> @@ -56,6 +56,7 @@ struct media_device_info { >> #define MEDIA_ENT_T_V4L2_SUBDEV_SENSOR (MEDIA_ENT_T_V4L2_SUBDEV + >> 1) >> #define MEDIA_ENT_T_V4L2_SUBDEV_FLASH (MEDIA_ENT_T_V4L2_SUBDEV + 2) >> #define MEDIA_ENT_T_V4L2_SUBDEV_LENS (MEDIA_ENT_T_V4L2_SUBDEV + 3) >> +#define MEDIA_ENT_T_V4L2_SUBDEV_DECODER (MEDIA_ENT_T_V4L2_SUBDEV + >> 4) > > > Such a new entity type needs to be documented in the media DocBook [1]. > It probably also deserves a comment here, as DECODER isn't that obvious > like the other already existing entity types. I heard people referring > to a device that encodes analog (composite) video signal into its digital > representation as an ENCODER. :) > > Thanks for pointing it :), I'll document it and post a v2. Regards, --Prabhakar Lad > [1] http://hverkuil.home.xs4all.nl/spec/media.html#media-ioc-enum-entities > > -- > > Regards, > Sylwester
diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h index 0ef8833..fa44ed9 100644 --- a/include/uapi/linux/media.h +++ b/include/uapi/linux/media.h @@ -56,6 +56,7 @@ struct media_device_info { #define MEDIA_ENT_T_V4L2_SUBDEV_SENSOR (MEDIA_ENT_T_V4L2_SUBDEV + 1) #define MEDIA_ENT_T_V4L2_SUBDEV_FLASH (MEDIA_ENT_T_V4L2_SUBDEV + 2) #define MEDIA_ENT_T_V4L2_SUBDEV_LENS (MEDIA_ENT_T_V4L2_SUBDEV + 3) +#define MEDIA_ENT_T_V4L2_SUBDEV_DECODER (MEDIA_ENT_T_V4L2_SUBDEV + 4) #define MEDIA_ENT_FL_DEFAULT (1 << 0)