diff mbox

[v2] mmc: davinci: allow driver to work without DMA resource

Message ID 1360066944-14265-1-git-send-email-prakash.pm@ti.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Manjunathappa, Prakash Feb. 5, 2013, 12:22 p.m. UTC
Do not return probe failure with missing DMA resources,
allow driver to work in PIO mode.
Tested on da850-evm by mounting partition followed by
file creation and deletion.

Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
---
Since v1:
Specified missing DMA resource(RX/TX).

 drivers/mmc/host/davinci_mmc.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

Comments

Manjunathappa, Prakash Feb. 22, 2013, 1:03 p.m. UTC | #1
Hi Chris,

As there are no comments, Could you please accept this patch?

Thanks,
Prakash

On Tue, Feb 05, 2013 at 17:52:24, Manjunathappa, Prakash wrote:
> Do not return probe failure with missing DMA resources,
> allow driver to work in PIO mode.
> Tested on da850-evm by mounting partition followed by
> file creation and deletion.
> 
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
> ---
> Since v1:
> Specified missing DMA resource(RX/TX).
> 
>  drivers/mmc/host/davinci_mmc.c |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
> index 2063677..27123f8 100644
> --- a/drivers/mmc/host/davinci_mmc.c
> +++ b/drivers/mmc/host/davinci_mmc.c
> @@ -1190,13 +1190,15 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
>  
>  	r = platform_get_resource(pdev, IORESOURCE_DMA, 0);
>  	if (!r)
> -		goto out;
> -	host->rxdma = r->start;
> +		dev_warn(&pdev->dev, "RX DMA resource not specified\n");
> +	else
> +		host->rxdma = r->start;
>  
>  	r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
>  	if (!r)
> -		goto out;
> -	host->txdma = r->start;
> +		dev_warn(&pdev->dev, "TX DMA resource not specified\n");
> +	else
> +		host->txdma = r->start;
>  
>  	host->mem_res = mem;
>  	host->base = ioremap(mem->start, mem_size);
> -- 
> 1.7.4.1
> 
>
Sekhar Nori Feb. 28, 2013, 11 a.m. UTC | #2
On 2/5/2013 5:52 PM, Manjunathappa, Prakash wrote:
> Do not return probe failure with missing DMA resources,
> allow driver to work in PIO mode.
> Tested on da850-evm by mounting partition followed by
> file creation and deletion.
> 
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>

I verified this along with your other patches enabling use of MMC with
DT boot.

Tested-by: Sekhar Nori <nsekhar@ti.com>

Thanks,
Sekhar
Chris Ball March 22, 2013, 4:05 p.m. UTC | #3
Hi,

On Thu, Feb 28 2013, Sekhar Nori wrote:
> On 2/5/2013 5:52 PM, Manjunathappa, Prakash wrote:
>> Do not return probe failure with missing DMA resources,
>> allow driver to work in PIO mode.
>> Tested on da850-evm by mounting partition followed by
>> file creation and deletion.
>> 
>> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
>
> I verified this along with your other patches enabling use of MMC with
> DT boot.
>
> Tested-by: Sekhar Nori <nsekhar@ti.com>

Thanks, pushed to mmc-next for 3.10.

- Chris.
diff mbox

Patch

diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index 2063677..27123f8 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -1190,13 +1190,15 @@  static int __init davinci_mmcsd_probe(struct platform_device *pdev)
 
 	r = platform_get_resource(pdev, IORESOURCE_DMA, 0);
 	if (!r)
-		goto out;
-	host->rxdma = r->start;
+		dev_warn(&pdev->dev, "RX DMA resource not specified\n");
+	else
+		host->rxdma = r->start;
 
 	r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
 	if (!r)
-		goto out;
-	host->txdma = r->start;
+		dev_warn(&pdev->dev, "TX DMA resource not specified\n");
+	else
+		host->txdma = r->start;
 
 	host->mem_res = mem;
 	host->base = ioremap(mem->start, mem_size);