From patchwork Thu Apr 18 17:13:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 2461881 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by patchwork1.kernel.org (Postfix) with ESMTP id 409DF3FCA5 for ; Thu, 18 Apr 2013 17:17:53 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id r3IHE2ix010774; Thu, 18 Apr 2013 12:14:02 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r3IHE2Tt010237; Thu, 18 Apr 2013 12:14:02 -0500 Received: from dlelxv23.itg.ti.com (172.17.1.198) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.2.342.3; Thu, 18 Apr 2013 12:14:02 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlelxv23.itg.ti.com (8.13.8/8.13.8) with ESMTP id r3IHE1dj020254; Thu, 18 Apr 2013 12:14:01 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id B59E88062C; Thu, 18 Apr 2013 12:14:00 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp52.itg.ti.com (dflp52.itg.ti.com [128.247.22.96]) by linux.omap.com (Postfix) with ESMTP id 750D280626 for ; Thu, 18 Apr 2013 12:13:57 -0500 (CDT) Received: from white.ext.ti.com (white.ext.ti.com [192.94.93.38]) by dflp52.itg.ti.com (8.13.7/8.13.8) with ESMTP id r3IHDv2M013377 for ; Thu, 18 Apr 2013 12:13:57 -0500 (CDT) Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by white.ext.ti.com (8.13.7/8.13.7) with ESMTP id r3IHDuHs001933 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Apr 2013 12:13:57 -0500 Received: from [216.82.250.51:65350] by server-16.bemta-12.messagelabs.com id 6E/03-13489-4D920715; Thu, 18 Apr 2013 17:13:56 +0000 X-Env-Sender: wsa@the-dreams.de X-Msg-Ref: server-6.tower-108.messagelabs.com!1366305234!11201309!1 X-Originating-IP: [89.238.76.85] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.8.6.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 315 invoked from network); 18 Apr 2013 17:13:56 -0000 Received: from sauhun.de (HELO pokefinder.org) (89.238.76.85) by server-6.tower-108.messagelabs.com with AES256-SHA encrypted SMTP; 18 Apr 2013 17:13:56 -0000 Received: from dslc-082-082-090-243.pools.arcor-ip.net ([82.82.90.243]:39168 helo=localhost) by pokefinder.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1USsPB-00075Y-JX; Thu, 18 Apr 2013 19:13:53 +0200 From: Wolfram Sang To: Subject: [PATCH 2/3] i2c: designware-plat: drop superfluous {get|put}_device Date: Thu, 18 Apr 2013 19:13:37 +0200 Message-ID: <1366305218-22817-3-git-send-email-wsa@the-dreams.de> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1366305218-22817-1-git-send-email-wsa@the-dreams.de> References: <1366305218-22817-1-git-send-email-wsa@the-dreams.de> CC: , Wolfram Sang , Viresh Kumar , Andy Shevchenko , Mika Westerberg X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com Driver core already takes care of refcounting, no need to do this on driver level again. Signed-off-by: Wolfram Sang Tested-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-platdrv.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index dec939a..f7549b6 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -170,9 +170,6 @@ static int dw_i2c_probe(struct platform_device *pdev) of_i2c_register_devices(adap); acpi_i2c_register_devices(adap); - /* Increase reference counter */ - get_device(&pdev->dev); - pm_runtime_set_autosuspend_delay(&pdev->dev, 1000); pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_set_active(&pdev->dev); @@ -188,7 +185,6 @@ static int dw_i2c_remove(struct platform_device *pdev) pm_runtime_get_sync(&pdev->dev); i2c_del_adapter(&dev->adapter); - put_device(&pdev->dev); i2c_dw_disable(dev);