From patchwork Fri Apr 19 09:53:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 2464191 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by patchwork2.kernel.org (Postfix) with ESMTP id 95E27DF25A for ; Fri, 19 Apr 2013 09:54:06 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id r3J9s6wA028614 for ; Fri, 19 Apr 2013 04:54:06 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r3J9s5Lb012139 for ; Fri, 19 Apr 2013 04:54:06 -0500 Received: from dlelxv24.itg.ti.com (172.17.1.199) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.2.342.3; Fri, 19 Apr 2013 04:54:05 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlelxv24.itg.ti.com (8.13.8/8.13.8) with ESMTP id r3J9s5E9019463 for ; Fri, 19 Apr 2013 04:54:05 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 2F7548063F for ; Fri, 19 Apr 2013 04:54:05 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp53.itg.ti.com (dflp53.itg.ti.com [128.247.5.6]) by linux.omap.com (Postfix) with ESMTP id 23A4A80626 for ; Fri, 19 Apr 2013 04:53:57 -0500 (CDT) Received: from neches.ext.ti.com (neches.ext.ti.com [192.91.81.29]) by dflp53.itg.ti.com (8.13.8/8.13.8) with ESMTP id r3J9rumH026380 for ; Fri, 19 Apr 2013 04:53:56 -0500 (CDT) Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by neches.ext.ti.com (8.13.7/8.13.7) with ESMTP id r3J9ruwo006516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Apr 2013 04:53:56 -0500 Received: from [216.82.253.147:47086] by server-4.bemta-7.messagelabs.com id CB/8B-30013-43411715; Fri, 19 Apr 2013 09:53:56 +0000 X-Env-Sender: prabhakar.csengg@gmail.com X-Msg-Ref: server-15.tower-165.messagelabs.com!1366365234!12032774!1 X-Originating-IP: [209.85.220.47] X-SpamReason: No, hits=0.0 required=7.0 tests=ML_RADAR_SPEW_LINKS_14, spamassassin: X-StarScan-Received: X-StarScan-Version: 6.8.6.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 6713 invoked from network); 19 Apr 2013 09:53:55 -0000 Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by server-15.tower-165.messagelabs.com with RC4-SHA encrypted SMTP; 19 Apr 2013 09:53:55 -0000 Received: by mail-pa0-f47.google.com with SMTP id bj1so251475pad.34 for ; Fri, 19 Apr 2013 02:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=+bmEuz9WXSTp3knqzD8r+ucN5jwKBlGMDMyQB8BKi6k=; b=uic8JMeYKQ4RaTmOrWiNhaRZeI85I/u0201FNEkHtz3b3R77ehQymXxXpo3fCXl+nL A2ky/aoYZHKLMIPIoNZa7hjunRz5OyI/VcO1x3XqI4Y9b2+WCwflG0meYPlTsbkGPI8R BJ8/GF6ZAPEyDQ3uEd4I44CKLkPywc8vQjHFCqrDNzYo5r0q0tRgMeIO79qgEz8j+utQ C7BCwKbYUoIpEAwkvibh9P7fMmbrzg525Vlf29xH1nfQVCC4fFMjvFxOZqw8RuacUT6a F+AAaZo7CT4nAzpHYISL51gm+Uet47j35HxhlBvwrmVM1mIk2CFdX9dSB9kwmj1qVngY Ldww== X-Received: by 10.68.185.162 with SMTP id fd2mr18275949pbc.176.1366365234712; Fri, 19 Apr 2013 02:53:54 -0700 (PDT) Received: from localhost.localdomain ([59.98.241.1]) by mx.google.com with ESMTPS id do4sm12914270pbc.8.2013.04.19.02.53.50 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 19 Apr 2013 02:53:53 -0700 (PDT) From: Prabhakar lad To: LMML Subject: [PATCH 2/2] media: davinci: vpif_display: move displaying of error to approppraite place Date: Fri, 19 Apr 2013 15:23:30 +0530 Message-ID: <1366365210-3778-3-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1366365210-3778-1-git-send-email-prabhakar.csengg@gmail.com> References: <1366365210-3778-1-git-send-email-prabhakar.csengg@gmail.com> CC: DLOS , Hans Verkuil , Mauro Carvalho Chehab , LKML X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: Errors-To: davinci-linux-open-source-bounces+patchwork-davinci=patchwork.kernel.org@linux.davincidsp.com From: Lad, Prabhakar this patch moves the displaying out error case "VPIF IRQ request failed\n" when there is actual request_irq() fail. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_display.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/davinci/vpif_display.c index d833056..7b17368 100644 --- a/drivers/media/platform/davinci/vpif_display.c +++ b/drivers/media/platform/davinci/vpif_display.c @@ -1725,6 +1725,7 @@ static __init int vpif_probe(struct platform_device *pdev) for (j = 0; j < i; j++) free_irq(j, (void *) (&vpif_obj.dev[res_idx]->channel_id)); + vpif_err("VPIF IRQ request failed\n"); goto vpif_int_err; } } @@ -1878,7 +1879,6 @@ vpif_sd_error: } vpif_int_err: v4l2_device_unregister(&vpif_obj.v4l2_dev); - vpif_err("VPIF IRQ request failed\n"); for (i = 0; i < res_idx; i++) { res = platform_get_resource(pdev, IORESOURCE_IRQ, i); for (j = res->start; j <= res->end; j++)