From patchwork Fri May 10 04:48:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 2548361 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by patchwork1.kernel.org (Postfix) with ESMTP id ED4473FC5A for ; Fri, 10 May 2013 04:50:54 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id r4A4nRra014590; Thu, 9 May 2013 23:49:28 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r4A4nRbF007605; Thu, 9 May 2013 23:49:27 -0500 Received: from dlelxv23.itg.ti.com (172.17.1.198) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.2.342.3; Thu, 9 May 2013 23:49:27 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlelxv23.itg.ti.com (8.13.8/8.13.8) with ESMTP id r4A4nPcx001731; Thu, 9 May 2013 23:49:27 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id E1F2580627; Thu, 9 May 2013 23:49:23 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp53.itg.ti.com (dflp53.itg.ti.com [128.247.5.6]) by linux.omap.com (Postfix) with ESMTP id 1925780626 for ; Thu, 9 May 2013 23:49:18 -0500 (CDT) Received: from neches.ext.ti.com (neches.ext.ti.com [192.91.81.29]) by dflp53.itg.ti.com (8.13.8/8.13.8) with ESMTP id r4A4nGOE026311 for ; Thu, 9 May 2013 23:49:16 -0500 (CDT) Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by neches.ext.ti.com (8.13.7/8.13.7) with ESMTP id r4A4nFCj027226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 May 2013 23:49:16 -0500 Received: from [216.82.253.147:34957] by server-13.bemta-7.messagelabs.com id 5D/2F-24792-B4C7C815; Fri, 10 May 2013 04:49:15 +0000 X-Env-Sender: prabhakar.csengg@gmail.com X-Msg-Ref: server-11.tower-165.messagelabs.com!1368161354!10435941!1 X-Originating-IP: [209.85.192.171] X-SpamReason: No, hits=0.0 required=7.0 tests=ML_RADAR_SPEW_LINKS_14, spamassassin: X-StarScan-Received: X-StarScan-Version: 6.9.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 6502 invoked from network); 10 May 2013 04:49:15 -0000 Received: from mail-pd0-f171.google.com (HELO mail-pd0-f171.google.com) (209.85.192.171) by server-11.tower-165.messagelabs.com with RC4-SHA encrypted SMTP; 10 May 2013 04:49:15 -0000 Received: by mail-pd0-f171.google.com with SMTP id r11so2514279pdi.2 for ; Thu, 09 May 2013 21:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=u3/S1bjrIEqfYOJTbW6OmlNLxB+ED2GoLIC/w8JylNU=; b=0posdYcPEgzNk6psN/flqgyrQzPa9ku2vJ8Y/M0jgVLzDeVt5PTr7bC8EmZKtgg1jb n5PBbt7ad3cyNyYJjwbv4XSQ9dM15eVnzxEr0gGb9p7bBDjSGUtUfHMtYx7ynjIWwprG /9nCy4PvxKOF5jr706d9ObrxxY/yoxDlip5fTEiDx1SEueVB2VpBMO6q11N+6TI9Twai 68sTIZ1C+JF0zOwCpM/pOjvUIR251+GYPzsSuti72lpUH68bgSjz8Zr5gnRyolDDxwHA 8277G8NzVqT11vNl+Z2O3IVeb6fwuy+3gpTs5X0mdddm7NeL9VkqBgmkuQr2aVTJMnAz 5y0w== X-Received: by 10.68.229.138 with SMTP id sq10mr15529126pbc.38.1368161354388; Thu, 09 May 2013 21:49:14 -0700 (PDT) Received: from localhost.localdomain ([59.98.240.135]) by mx.google.com with ESMTPSA id dr6sm1217116pac.11.2013.05.09.21.49.10 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 09 May 2013 21:49:13 -0700 (PDT) From: Lad Prabhakar To: LMML , DLOS Subject: [PATCH] davinci: vpfe: fix error path in probe Date: Fri, 10 May 2013 10:18:38 +0530 Message-ID: <1368161318-16128-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.7.4.1 CC: LKML , Mauro Carvalho Chehab X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com From: Lad, Prabhakar The error path on failure was calling mutex_unlock(), but there was no actuall call before for mutex_lock(). This patch fixes this issue by pointing it to proper go label. Reported-by: Jose Pablo Carballo Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpfe_capture.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c index 8c50d30..3827fe1 100644 --- a/drivers/media/platform/davinci/vpfe_capture.c +++ b/drivers/media/platform/davinci/vpfe_capture.c @@ -1837,7 +1837,7 @@ static int vpfe_probe(struct platform_device *pdev) if (NULL == ccdc_cfg) { v4l2_err(pdev->dev.driver, "Memory allocation failed for ccdc_cfg\n"); - goto probe_free_lock; + goto probe_free_dev_mem; } mutex_lock(&ccdc_lock);