| Message ID | 1368619042-28252-3-git-send-email-prabhakar.csengg@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Prabhakar, Thank you for the patch. On Wednesday 15 May 2013 17:27:18 Lad Prabhakar wrote: > From: Lad, Prabhakar <prabhakar.csengg@gmail.com> > > remove init_enable from ths7303 pdata as it is no longer exists. You should move this before 1/6, otherwise you will break bisection. > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> > Cc: Sekhar Nori <nsekhar@ti.com> > Cc: Hans Verkuil <hans.verkuil@cisco.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Mauro Carvalho Chehab <mchehab@redhat.com> > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: Sakari Ailus <sakari.ailus@iki.fi> > Cc: linux-kernel@vger.kernel.org > Cc: davinci-linux-open-source@linux.davincidsp.com > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm/mach-davinci/board-dm365-evm.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-davinci/board-dm365-evm.c > b/arch/arm/mach-davinci/board-dm365-evm.c index 2a66743..4e02ae7 100644 > --- a/arch/arm/mach-davinci/board-dm365-evm.c > +++ b/arch/arm/mach-davinci/board-dm365-evm.c > @@ -510,7 +510,6 @@ struct ths7303_platform_data ths7303_pdata = { > .ch_1 = 3, > .ch_2 = 3, > .ch_3 = 3, > - .init_enable = 1, > }; > > static struct amp_config_info vpbe_amp = {
Hi Laurent, Thanks for the review. On Wed, May 15, 2013 at 5:35 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Wednesday 15 May 2013 17:27:18 Lad Prabhakar wrote: >> From: Lad, Prabhakar <prabhakar.csengg@gmail.com> >> >> remove init_enable from ths7303 pdata as it is no longer exists. > > You should move this before 1/6, otherwise you will break bisection. > OK I'll fix it in next version. Regards, --Prabhakar Lad
Hi Laurent, On Wed, May 15, 2013 at 5:41 PM, Prabhakar Lad <prabhakar.csengg@gmail.com> wrote: > Hi Laurent, > > Thanks for the review. > > On Wed, May 15, 2013 at 5:35 PM, Laurent Pinchart > <laurent.pinchart@ideasonboard.com> wrote: >> Hi Prabhakar, >> >> Thank you for the patch. >> >> On Wednesday 15 May 2013 17:27:18 Lad Prabhakar wrote: >>> From: Lad, Prabhakar <prabhakar.csengg@gmail.com> >>> >>> remove init_enable from ths7303 pdata as it is no longer exists. >> >> You should move this before 1/6, otherwise you will break bisection. >> How about I just reshuffles while issuing a pull rather than resending the whole series ? Regards, --Prabhakar Lad
Hi Prabhakar, On Thursday 16 May 2013 17:18:00 Prabhakar Lad wrote: > On Wed, May 15, 2013 at 5:41 PM, Prabhakar Lad wrote: > > On Wed, May 15, 2013 at 5:35 PM, Laurent Pinchart wrote: > >> On Wednesday 15 May 2013 17:27:18 Lad Prabhakar wrote: > >>> From: Lad, Prabhakar <prabhakar.csengg@gmail.com> > >>> > >>> remove init_enable from ths7303 pdata as it is no longer exists. > >> > >> You should move this before 1/6, otherwise you will break bisection. > > How about I just reshuffles while issuing a pull rather than resending > the whole series ? As long as you don't forget to do so, sure :-)
Hi Sekhar, On Wed, May 15, 2013 at 5:27 PM, Lad Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad, Prabhakar <prabhakar.csengg@gmail.com> > > remove init_enable from ths7303 pdata as it is no longer exists. > Can you please ack this patch, as this patch is intended to go via media tree. Regards, --Prabhakar Lad
diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c index 2a66743..4e02ae7 100644 --- a/arch/arm/mach-davinci/board-dm365-evm.c +++ b/arch/arm/mach-davinci/board-dm365-evm.c @@ -510,7 +510,6 @@ struct ths7303_platform_data ths7303_pdata = { .ch_1 = 3, .ch_2 = 3, .ch_3 = 3, - .init_enable = 1, }; static struct amp_config_info vpbe_amp = {