| Message ID | 1368689438-23889-3-git-send-email-prabhakar.csengg@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 16-05-2013 11:30, Lad Prabhakar wrote: > From: Lad, Prabhakar <prabhakar.csengg@gmail.com> > This patch removes unwanted header inclusion Why are they unwanted? > and sorts them alphabetically In the subject you typed "the" instead of "them". > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> WBR, Sergei
Hi Sergei, Thanks for the review. On Fri, May 17, 2013 at 12:25 AM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 16-05-2013 11:30, Lad Prabhakar wrote: > >> From: Lad, Prabhakar <prabhakar.csengg@gmail.com> > > >> This patch removes unwanted header inclusion > > > Why are they unwanted? > The driver builds without this includes. This is arguable, if I would have added a new driver with the only #includes which were required to build thats accepted. But when I remove unnecessary #includes from the existing drivers that's not acceptable ? This applies to rest of the similar patches in the series. >> and sorts them alphabetically > > > In the subject you typed "the" instead of "them". > Hmm carry forwarded this copy paste error every where will fix it in V2. Regards, --Prabhakar Lad
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index 860e15d..609f6d1 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c @@ -29,43 +29,19 @@ * PHY layer usage */ -#include <linux/module.h> -#include <linux/kernel.h> -#include <linux/sched.h> -#include <linux/string.h> -#include <linux/timer.h> -#include <linux/errno.h> -#include <linux/in.h> -#include <linux/ioport.h> -#include <linux/slab.h> -#include <linux/mm.h> +#include <linux/clk.h> +#include <linux/davinci_emac.h> +#include <linux/dma-mapping.h> +#include <linux/etherdevice.h> +#include <linux/io.h> #include <linux/interrupt.h> -#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> #include <linux/netdevice.h> -#include <linux/etherdevice.h> -#include <linux/skbuff.h> -#include <linux/ethtool.h> -#include <linux/highmem.h> -#include <linux/proc_fs.h> -#include <linux/ctype.h> -#include <linux/spinlock.h> -#include <linux/dma-mapping.h> -#include <linux/clk.h> -#include <linux/platform_device.h> -#include <linux/semaphore.h> +#include <linux/of_net.h> #include <linux/phy.h> -#include <linux/bitops.h> -#include <linux/io.h> -#include <linux/uaccess.h> +#include <linux/platform_device.h> #include <linux/pm_runtime.h> -#include <linux/davinci_emac.h> -#include <linux/of.h> -#include <linux/of_address.h> -#include <linux/of_irq.h> -#include <linux/of_net.h> - -#include <asm/irq.h> -#include <asm/page.h> #include "davinci_cpdma.h"