From patchwork Sat May 25 17:39:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 2613781 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by patchwork2.kernel.org (Postfix) with ESMTP id B03B0DF2A2 for ; Sat, 25 May 2013 17:40:39 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id r4PHediF005447 for ; Sat, 25 May 2013 12:40:39 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r4PHedIh001250 for ; Sat, 25 May 2013 12:40:39 -0500 Received: from dlelxv24.itg.ti.com (172.17.1.199) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.2.342.3; Sat, 25 May 2013 12:40:38 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlelxv24.itg.ti.com (8.13.8/8.13.8) with ESMTP id r4PHec6q028477 for ; Sat, 25 May 2013 12:40:38 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id AA4D480627 for ; Sat, 25 May 2013 12:40:38 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp51.itg.ti.com (dflp51.itg.ti.com [128.247.22.94]) by linux.omap.com (Postfix) with ESMTP id AA8FE80626 for ; Sat, 25 May 2013 12:40:21 -0500 (CDT) Received: from medina.ext.ti.com (medina.ext.ti.com [192.91.81.31]) by dflp51.itg.ti.com (8.13.7/8.13.8) with ESMTP id r4PHeLgs005112 for ; Sat, 25 May 2013 12:40:21 -0500 (CDT) Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by medina.ext.ti.com (8.13.7/8.13.7) with ESMTP id r4PHeK4O001760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 25 May 2013 12:40:21 -0500 Received: from [216.82.250.51:13216] by server-11.bemta-12.messagelabs.com id 1B/F1-26064-487F0A15; Sat, 25 May 2013 17:40:20 +0000 X-Env-Sender: prabhakar.csengg@gmail.com X-Msg-Ref: server-11.tower-108.messagelabs.com!1369503618!13094562!1 X-Originating-IP: [209.85.220.50] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG, ML_RADAR_SPEW_LINKS_14,spamassassin: X-StarScan-Received: X-StarScan-Version: 6.9.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 22475 invoked from network); 25 May 2013 17:40:19 -0000 Received: from mail-pa0-f50.google.com (HELO mail-pa0-f50.google.com) (209.85.220.50) by server-11.tower-108.messagelabs.com with RC4-SHA encrypted SMTP; 25 May 2013 17:40:19 -0000 Received: by mail-pa0-f50.google.com with SMTP id fb11so4017046pad.23 for ; Sat, 25 May 2013 10:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=mwfDxoW7rNq99EvF70q5NT6Ne9On23n5Y5/vETWcK9M=; b=RQx4zyTGtJ9/4dxvlOpU9np8bN7sS7qY+0n8RR1W9N8J/J1eWbkG2rJvInwwQJq0FJ R/LOT5gd87285WFmswkh6QiJgyEW6cqgAUEnS9TRRzRqeQYjgqjQElvgE1tl3T7NXwSs 8WpAzaNtOKshVWolJrbky2XR5Anjdb1Pid2kBrAeKrf+EpPb4Nv+ztRbC646NdOH+qKJ YeAQ1UTVnT6kcxkJUZm8V/Onf0I6kIBTOAY+X9p4d0KHxBwi1fPwqjehNaPJLbx8h2fU 86v+J14tDLdtcNjaG7Vq+Ko4WJtrXJ7wdo96SiQSkG1D1NsqVjCsoz3StluSkrKTIeYq 86SQ== X-Received: by 10.66.144.98 with SMTP id sl2mr23499692pab.92.1369503618693; Sat, 25 May 2013 10:40:18 -0700 (PDT) Received: from localhost.localdomain ([112.79.40.180]) by mx.google.com with ESMTPSA id gi2sm21262517pbb.2.2013.05.25.10.40.09 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 25 May 2013 10:40:17 -0700 (PDT) From: Prabhakar Lad To: Hans Verkuil , Mauro Carvalho Chehab , LMML , Laurent Pinchart Subject: [PATCH v2 2/4] media: i2c: ths7303: remove init_enable option from pdata Date: Sat, 25 May 2013 23:09:34 +0530 Message-ID: <1369503576-22271-3-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1369503576-22271-1-git-send-email-prabhakar.csengg@gmail.com> References: <1369503576-22271-1-git-send-email-prabhakar.csengg@gmail.com> CC: DLOS , Mauro Carvalho Chehab , LKML , Hans Verkuil , Laurent Pinchart X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: Errors-To: davinci-linux-open-source-bounces+patchwork-davinci=patchwork.kernel.org@linux.davincidsp.com From: Lad, Prabhakar This patch removes init_enable option from pdata, the init_enable was intended that the device should start streaming video immediately but ideally the bridge drivers should call s_stream explicitly for such devices to start video. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org Cc: davinci-linux-open-source@linux.davincidsp.com --- drivers/media/i2c/ths7303.c | 4 +--- include/media/ths7303.h | 2 -- 2 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c index 65853ee..8cddcd0 100644 --- a/drivers/media/i2c/ths7303.c +++ b/drivers/media/i2c/ths7303.c @@ -356,9 +356,7 @@ static int ths7303_setup(struct v4l2_subdev *sd) int ret; u8 mask; - state->stream_on = pdata->init_enable; - - mask = state->stream_on ? 0xff : 0xf8; + mask = 0xf8; ret = ths7303_write(sd, THS7303_CHANNEL_1, pdata->ch_1 & mask); if (ret) diff --git a/include/media/ths7303.h b/include/media/ths7303.h index 980ec51..a7b4929 100644 --- a/include/media/ths7303.h +++ b/include/media/ths7303.h @@ -30,13 +30,11 @@ * @ch_1: Bias value for channel one. * @ch_2: Bias value for channel two. * @ch_3: Bias value for channel three. - * @init_enable: initalize on init. */ struct ths7303_platform_data { u8 ch_1; u8 ch_2; u8 ch_3; - u8 init_enable; }; #endif