| Message ID | 1371314050-25866-1-git-send-email-prabhakar.csengg@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Prabhakar, Thanks for the patch. On Saturday 15 June 2013 22:04:10 Prabhakar Lad wrote: > From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> > > This patch removes the driver_data member from ths7303_state structure. > The driver_data member was intended to differentiate between ths7303 and > ths7353 chip and get the g_chip_ident, But as of now g_chip_ident is > obsolete, so there is no need of driver_data. What tree it this based on ? linuxtv/master still uses driver_data in the ths7303_g_chip_ident() function. > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> > --- > drivers/media/i2c/ths7303.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c > index 2e17abc..0a2dacb 100644 > --- a/drivers/media/i2c/ths7303.c > +++ b/drivers/media/i2c/ths7303.c > @@ -38,7 +38,6 @@ struct ths7303_state { > struct v4l2_bt_timings bt; > int std_id; > int stream_on; > - int driver_data; > }; > > enum ths7303_filter_mode { > @@ -355,9 +354,6 @@ static int ths7303_probe(struct i2c_client *client, > sd = &state->sd; > v4l2_i2c_subdev_init(sd, client, &ths7303_ops); > > - /* store the driver data to differntiate the chip */ > - state->driver_data = (int)id->driver_data; > - > /* set to default 480I_576I filter mode */ > if (ths7303_setval(sd, THS7303_FILTER_MODE_480I_576I) < 0) { > v4l_err(client, "Setting to 480I_576I filter mode failed!\n");
Hi Laurent, On Sun, Jun 16, 2013 at 5:21 AM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > Hi Prabhakar, > > Thanks for the patch. > > On Saturday 15 June 2013 22:04:10 Prabhakar Lad wrote: >> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> >> >> This patch removes the driver_data member from ths7303_state structure. >> The driver_data member was intended to differentiate between ths7303 and >> ths7353 chip and get the g_chip_ident, But as of now g_chip_ident is >> obsolete, so there is no need of driver_data. > > What tree it this based on ? linuxtv/master still uses driver_data in the > ths7303_g_chip_ident() function. > Ah forgot to mention this is based on Hans's branch http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/for-v3.11 Regards, --Prabhakar Lad
diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c index 2e17abc..0a2dacb 100644 --- a/drivers/media/i2c/ths7303.c +++ b/drivers/media/i2c/ths7303.c @@ -38,7 +38,6 @@ struct ths7303_state { struct v4l2_bt_timings bt; int std_id; int stream_on; - int driver_data; }; enum ths7303_filter_mode { @@ -355,9 +354,6 @@ static int ths7303_probe(struct i2c_client *client, sd = &state->sd; v4l2_i2c_subdev_init(sd, client, &ths7303_ops); - /* store the driver data to differntiate the chip */ - state->driver_data = (int)id->driver_data; - /* set to default 480I_576I filter mode */ if (ths7303_setval(sd, THS7303_FILTER_MODE_480I_576I) < 0) { v4l_err(client, "Setting to 480I_576I filter mode failed!\n");