| Message ID | 1387293923-27236-1-git-send-email-prabhakar.csengg@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Hans, On Tue, Dec 17, 2013 at 8:55 PM, Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> > > This patch includes linux/delay.h required for msleep, > which fixes following build error. > > dm365_isif.c: In function ‘isif_enable’: > dm365_isif.c:129:2: error: implicit declaration of function ‘msleep’ > Will you pick this patch or shall I go ahead and issue a pull to Mauro ? Regards, --Prabhakar Lad
I just made a patch myself that I added to the pull request I just posted. You didn't CC me or CC the linux-media list when you posted your patch, so I never saw it. Regards, Hans On 12/20/2013 01:47 PM, Prabhakar Lad wrote: > Hi Hans, > > On Tue, Dec 17, 2013 at 8:55 PM, Lad, Prabhakar > <prabhakar.csengg@gmail.com> wrote: >> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> >> >> This patch includes linux/delay.h required for msleep, >> which fixes following build error. >> >> dm365_isif.c: In function ‘isif_enable’: >> dm365_isif.c:129:2: error: implicit declaration of function ‘msleep’ >> > Will you pick this patch or shall I go ahead and issue a pull to Mauro ? > > Regards, > --Prabhakar Lad > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Hi Hans, On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote: > I just made a patch myself that I added to the pull request I just posted. > > You didn't CC me or CC the linux-media list when you posted your patch, so I > never saw it. > I dont know why this patch didnt make up in linux-media but its present DLOS [1]. I posted it the same day when you pinged me about this issue. Anyway your patch too didnt reach me and I also cannot find it in the ML. May be you directly issued the pull ? [1] https://patchwork.kernel.org/patch/3362211/ Regards, --Prabhakar Lad
Hi Prabhakar, On 12/20/2013 02:02 PM, Prabhakar Lad wrote: > Hi Hans, > > On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote: >> I just made a patch myself that I added to the pull request I just posted. >> >> You didn't CC me or CC the linux-media list when you posted your patch, so I >> never saw it. >> > I dont know why this patch didnt make up in linux-media but its > present DLOS [1]. If it's not mailed to linux-media, then it doesn't end up in linux-media patchwork, and then I won't see it when I process pending patches. While I am subscribed to DLOS I do not actually read it unless I know there is something that I need to pay attention to. > I posted it the same day when you pinged me about this issue. I was a bit surprised that I didn't see a patch for this, you are very prompt normally :-) > Anyway your patch > too didnt reach me and I also cannot find it in the ML. May be you > directly issued the pull ? I directly issued the pull. It was such a trivial change. Regards, Hans > > [1] https://patchwork.kernel.org/patch/3362211/ > > Regards, > --Prabhakar Lad > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Hi Hans, On Fri, Dec 20, 2013 at 7:00 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote: > Hi Prabhakar, > > On 12/20/2013 02:02 PM, Prabhakar Lad wrote: >> Hi Hans, >> >> On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote: >>> I just made a patch myself that I added to the pull request I just posted. >>> >>> You didn't CC me or CC the linux-media list when you posted your patch, so I >>> never saw it. >>> >> I dont know why this patch didnt make up in linux-media but its >> present DLOS [1]. > > If it's not mailed to linux-media, then it doesn't end up in linux-media patchwork, > and then I won't see it when I process pending patches. > > While I am subscribed to DLOS I do not actually read it unless I know there is > something that I need to pay attention to. > This didnt land into linux-media becuase may be I sent it throught TI's network I usually send it via my home network. >> I posted it the same day when you pinged me about this issue. > > I was a bit surprised that I didn't see a patch for this, you are very prompt > normally :-) > :) >> Anyway your patch >> too didnt reach me and I also cannot find it in the ML. May be you >> directly issued the pull ? > > I directly issued the pull. It was such a trivial change. > No problem as long as its fixed :) Thanks, --Prabhakar Lad
diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.c b/drivers/staging/media/davinci_vpfe/dm365_isif.c index ff48fce..81d9306 100644 --- a/drivers/staging/media/davinci_vpfe/dm365_isif.c +++ b/drivers/staging/media/davinci_vpfe/dm365_isif.c @@ -19,6 +19,8 @@ * Prabhakar Lad <prabhakar.lad@ti.com> */ +#include <linux/delay.h> + #include "dm365_isif.h" #include "vpfe_mc_capture.h"