From patchwork Sat Sep 6 15:26:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 4857681 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BE0CA9F32F for ; Sat, 6 Sep 2014 15:28:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 04AD120138 for ; Sat, 6 Sep 2014 15:28:52 +0000 (UTC) Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15F522013A for ; Sat, 6 Sep 2014 15:28:51 +0000 (UTC) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s86FRrXM025633; Sat, 6 Sep 2014 10:27:53 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s86FRmO1011010; Sat, 6 Sep 2014 10:27:52 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Sat, 6 Sep 2014 10:27:50 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s86FRnuP020558; Sat, 6 Sep 2014 10:27:49 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id E78598062A; Sat, 6 Sep 2014 10:27:48 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dlelxv84.itg.ti.com (dlelxv84.itg.ti.com [172.17.0.246]) by linux.omap.com (Postfix) with ESMTP id 4F92780626 for ; Sat, 6 Sep 2014 10:27:44 -0500 (CDT) Received: from medina.ext.ti.com (medina.ext.ti.com [192.91.81.31]) by dlelxv84.itg.ti.com (8.14.3/8.13.8) with ESMTP id s86FRiCG015201 for ; Sat, 6 Sep 2014 10:27:44 -0500 Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by medina.ext.ti.com (8.13.7/8.13.7) with ESMTP id s86FRhRP001623 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 6 Sep 2014 10:27:44 -0500 Received: from [216.82.242.147:21601] by server-12.bemta-8.messagelabs.com id BE/D6-26875-FE72B045; Sat, 06 Sep 2014 15:27:43 +0000 X-Env-Sender: prabhakar.csengg@gmail.com X-Msg-Ref: server-5.tower-95.messagelabs.com!1410017262!30895889!1 X-Originating-IP: [74.125.82.173] X-SpamReason: No, hits=0.2 required=7.0 tests=ML_RADAR_SPEW_LINKS_14, RCVD_ILLEGAL_IP,spamassassin: X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13191 invoked from network); 6 Sep 2014 15:27:43 -0000 Received: from mail-we0-f173.google.com (HELO mail-we0-f173.google.com) (74.125.82.173) by server-5.tower-95.messagelabs.com with RC4-SHA encrypted SMTP; 6 Sep 2014 15:27:43 -0000 Received: by mail-we0-f173.google.com with SMTP id t60so13059047wes.32 for ; Sat, 06 Sep 2014 08:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YZqVqFUWWPPX7wsVCyPlhfTF9R/zov+Iq9aXAhVjCc4=; b=agMO3LQoh0ptPNPw8MkQO6rnkZ6JUgiL4V49SUNgPeYdAjC1Vuw44vPCajUO0kbCtg DnB+D7XWuF5V9reQURPRrceaemWTFXof73KJdYNwk/hyvdqGf12lS4XUD6RT2XQsSpaZ 9PcLRtFteRtlaDBJcqCGxVjPjqd8NWGWiZ8jxvzBCG3dvTrIUgvK5aLg6rEbOea7ZCcV KduEDTmccQvnWwBgY88wgNehS8pgJxcNp3QCzk6V6VjBsqYqbFgk26mJE4fbgxXRuEa8 gfVO7nn5joKdDmV+Qy/DOCZ/abuM5df2aqnLMJ70BoPh6kzw8XYfULy4Br6faKEWq1bx Ojug== X-Received: by 10.180.9.144 with SMTP id z16mr10788277wia.26.1410017261770; Sat, 06 Sep 2014 08:27:41 -0700 (PDT) Received: from tango-charlie.Home ([2.127.193.40]) by mx.google.com with ESMTPSA id bg10sm4831620wjc.47.2014.09.06.08.27.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 06 Sep 2014 08:27:40 -0700 (PDT) From: "Lad, Prabhakar" To: LMML Subject: [PATCH 2/5] media: davinci: vpif_capture: drop setting of vb2 buffer state to ACTIVE Date: Sat, 6 Sep 2014 16:26:48 +0100 Message-ID: <1410017211-15438-3-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1410017211-15438-1-git-send-email-prabhakar.csengg@gmail.com> References: <1410017211-15438-1-git-send-email-prabhakar.csengg@gmail.com> CC: DLOS , Hans Verkuil , LKML , Mauro Carvalho Chehab X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP this patch drops setting of vb2 buffer state to VB2_BUF_STATE_ACTIVE, as any buffer queued to the driver is marked ACTIVE by the vb2 core. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_capture.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index cf15bb1..881efcd 100644 --- a/drivers/media/platform/davinci/vpif_capture.c +++ b/drivers/media/platform/davinci/vpif_capture.c @@ -213,8 +213,6 @@ static int vpif_start_streaming(struct vb2_queue *vq, unsigned int count) /* Remove buffer from the buffer queue */ list_del(&common->cur_frm->list); spin_unlock_irqrestore(&common->irqlock, flags); - /* Mark state of the current frame to active */ - common->cur_frm->vb.state = VB2_BUF_STATE_ACTIVE; addr = vb2_dma_contig_plane_dma_addr(&common->cur_frm->vb, 0); @@ -350,7 +348,6 @@ static void vpif_schedule_next_buffer(struct common_obj *common) /* Remove that buffer from the buffer queue */ list_del(&common->next_frm->list); spin_unlock(&common->irqlock); - common->next_frm->vb.state = VB2_BUF_STATE_ACTIVE; addr = vb2_dma_contig_plane_dma_addr(&common->next_frm->vb, 0); /* Set top and bottom field addresses in VPIF registers */