From patchwork Wed Sep 2 16:28:25 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 45239 Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n82GSjxW010196 for ; Wed, 2 Sep 2009 16:28:45 GMT Received: from dlep36.itg.ti.com ([157.170.170.91]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id n82GQjt9004286; Wed, 2 Sep 2009 11:26:50 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by dlep36.itg.ti.com (8.13.8/8.13.8) with ESMTP id n82GQj4w018674; Wed, 2 Sep 2009 11:26:45 -0500 (CDT) Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id EC50780627; Wed, 2 Sep 2009 11:26:44 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp53.itg.ti.com (dflp53.itg.ti.com [128.247.5.6]) by linux.omap.com (Postfix) with ESMTP id 857B880626 for ; Wed, 2 Sep 2009 11:26:43 -0500 (CDT) Received: from white.ext.ti.com (localhost [127.0.0.1]) by dflp53.itg.ti.com (8.13.8/8.13.8) with ESMTP id n82GQgbh004479 for ; Wed, 2 Sep 2009 11:26:42 -0500 (CDT) Received: from mail145-va3-R.bigfish.com (mail-va3.bigfish.com [216.32.180.113]) by white.ext.ti.com (8.13.7/8.13.7) with ESMTP id n82GQblT001024 for ; Wed, 2 Sep 2009 11:26:42 -0500 Received: from mail145-va3 (localhost.localdomain [127.0.0.1]) by mail145-va3-R.bigfish.com (Postfix) with ESMTP id 168C819E0076 for ; Wed, 2 Sep 2009 16:26:37 +0000 (UTC) X-SpamScore: -5 X-BigFish: vps-5(zz936eMzz1202hzzz2dh6bh64h) X-Spam-TCS-SCL: 3:0 X-FB-SS: 5, X-MS-Exchange-Organization-Antispam-Report: OrigIP: 63.81.120.155; Service: EHS Received: by mail145-va3 (MessageSwitch) id 1251908795341927_14687; Wed, 2 Sep 2009 16:26:35 +0000 (UCT) Received: from imap.sh.mvista.com (unknown [63.81.120.155]) by mail145-va3.bigfish.com (Postfix) with ESMTP id E4951418055 for ; Wed, 2 Sep 2009 16:26:34 +0000 (UTC) Received: from wasted.dev.rtsoft.ru (unknown [10.150.0.9]) by imap.sh.mvista.com (Postfix) with ESMTP id 623CD3EC9; Wed, 2 Sep 2009 09:26:32 -0700 (PDT) From: Sergei Shtylyov Organization: MontaVista Software Inc. To: felipe.balbi@nokia.com, gregkh@suse.de Date: Wed, 2 Sep 2009 19:28:25 +0300 User-Agent: KMail/1.5 MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200909022028.25482.sshtylyov@ru.mvista.com> Cc: davinci-linux-open-source@linux.davincidsp.com, linux-usb@vger.kernel.org Subject: [PATCH] musb_gadget_ep0: fix unhandled endpoint 0 IRQs, again X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.4 Precedence: list List-Id: davinci-linux-open-source.linux.davincidsp.com List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: davinci-linux-open-source-bounces@linux.davincidsp.com Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com Commit a5073b52833e4df8e16c93dc4cbb7e0c558c74a2 (musb_gadget: fix unhandled endpoint 0 IRQs) somehow missed its key change: "The gadget EP0 code routinely ignores an interrupt at end of the data phase because of musb_g_ep0_giveback() resetting the state machine to "idle, waiting for SETUP" phase prematurely." So, the majority of the cases of unhandled IRQs is still unfixed... Signed-off-by: Sergei Shtylyov --- Please, apply it before 2.6.31 is out... drivers/usb/musb/musb_gadget_ep0.c | 1 - 1 files changed, 1 deletion(-) Index: linux-2.6/drivers/usb/musb/musb_gadget_ep0.c =================================================================== --- linux-2.6.orig/drivers/usb/musb/musb_gadget_ep0.c +++ linux-2.6/drivers/usb/musb/musb_gadget_ep0.c @@ -199,7 +199,6 @@ service_in_request(struct musb *musb, co static void musb_g_ep0_giveback(struct musb *musb, struct usb_request *req) { musb_g_giveback(&musb->endpoints[0].ep_in, req, 0); - musb->ep0_state = MUSB_EP0_STAGE_SETUP; } /*