From patchwork Fri Mar 21 15:56:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 3875151 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0E58FBF540 for ; Fri, 21 Mar 2014 15:57:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1BFFE20212 for ; Fri, 21 Mar 2014 15:57:34 +0000 (UTC) Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF78020203 for ; Fri, 21 Mar 2014 15:57:32 +0000 (UTC) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id s2LFuUrZ025084; Fri, 21 Mar 2014 10:56:30 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s2LFuSrV003967; Fri, 21 Mar 2014 10:56:29 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Fri, 21 Mar 2014 10:56:28 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s2LFuQhY016376; Fri, 21 Mar 2014 10:56:27 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 6073E80627; Fri, 21 Mar 2014 09:56:26 -0600 (CST) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflxv17.itg.ti.com (dflxv17.itg.ti.com [128.247.5.93]) by linux.omap.com (Postfix) with ESMTP id A357580626 for ; Fri, 21 Mar 2014 09:56:21 -0600 (CST) Received: from medina.ext.ti.com (medina.ext.ti.com [192.91.81.31]) by dflxv17.itg.ti.com (8.14.3/8.13.8) with ESMTP id s2LFuLKY015558 for ; Fri, 21 Mar 2014 10:56:21 -0500 Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by medina.ext.ti.com (8.13.7/8.13.7) with ESMTP id s2LFuKHs027866 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Mar 2014 10:56:21 -0500 Received: from [216.82.250.51:16398] by server-6.bemta-12.messagelabs.com id 55/2A-08935-4216C235; Fri, 21 Mar 2014 15:56:20 +0000 X-Env-Sender: arnd@arndb.de X-Msg-Ref: server-8.tower-108.messagelabs.com!1395417377!10599286!1 X-Originating-IP: [212.227.126.130] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 28674 invoked from network); 21 Mar 2014 15:56:18 -0000 Received: from moutng.kundenserver.de (HELO moutng.kundenserver.de) (212.227.126.130) by server-8.tower-108.messagelabs.com with DHE-RSA-AES128-SHA encrypted SMTP; 21 Mar 2014 15:56:18 -0000 Received: from klappe2.localnet (HSI-KBW-134-3-135-108.hsi14.kabel-badenwuerttemberg.de [134.3.135.108]) by mrelayeu.kundenserver.de (node=mreue007) with ESMTP (Nemesis) id 0LywdQ-1XDTey2atU-0148be; Fri, 21 Mar 2014 16:56:09 +0100 From: Arnd Bergmann To: Sekhar Nori Subject: Re: [PATCH 08/62] ARM: davinci: use explicit 'select' for DA850_EVM Date: Fri, 21 Mar 2014 16:56:05 +0100 User-Agent: KMail/1.12.2 (Linux/3.8.0-22-generic; KDE/4.3.2; x86_64; ; ) References: <1395257399-359545-1-git-send-email-arnd@arndb.de> <1395257399-359545-9-git-send-email-arnd@arndb.de> <532AE351.9000503@ti.com> In-Reply-To: <532AE351.9000503@ti.com> MIME-Version: 1.0 Message-ID: <201403211656.06007.arnd@arndb.de> X-Provags-ID: V02:K0:ai1JN5DhCBC6AEKGRYfGNfX8cBqxcxrSQD2mE8lIgrO Fd9lAW/n58Ojr+2hh9EEw4FjNVHcZyGEYhH+H6H6nkB+SR0YSY /YsgFgUOk+xTETZcutdfGTMq4z/Q/jNM6i3CSlFNvWK83/xJXg A7F4qGRplWawo6XU1WdyAGXy95Ul3FcVYkAcmFJI3Qatl0H3VQ /HD669pHJYvekoc+hX1ruvPmF1GecfjPQKsqEhflEovFVAKiSr ypy6ptrazzFRKrjMnc7cF46L9hQGW0iz9umm4L4fkOtnqbRo3X 3ds56FUhVmheaHI+GVDVKLsWsk4UWbx/FYPSJ3hSXmnjX+L4m5 P69NiB2WobtwgO3AldKnFuM3TBVbFrIiHbsnLmr4S CC: Kevin Hilman , , , X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thursday 20 March 2014, Sekhar Nori wrote: > On Thursday 20 March 2014 12:59 AM, Arnd Bergmann wrote: > > The DAVINCI_DA850_EVM board uses an unusual method to > > enable the GPIO_PCA953X and KEYBOARD_GPIO_POLLED symbols, > > which leads to the dependencies on these symbols being > > ignored. As GPIO_PCA953X actually requires I2C, that > > can lead to build failures when I2C is disabled. > > > > This patch removes the duplicate symbol definitions > > I am okay with this.. > > > and instead adds equivalent 'select' statements that > > are conditional on the underlying dependencies. > > .. but not sure this is needed. The PCA953X was defaulted to y mainly > because the IO expander was used to detect presence of daughter cards. > Even then, I don't think there is any need to force its selection. > > > > > A different question whether we actually want to automatically > > enable them at all or rather put them into defconfig, > > but that should be a separate patch. > > It can be enabled through defconfig as you said. I agree that can be a > separate patch. For now, just dropping the replicated Kconfig symbols > should be okay. Ok, even better then. I was trying to change the behavior as little as possible, but not selecting the drivers is certainly the correct approach. I've put the two symbols into the defconfig now so the builds are unchanged. Arnd 8<---- >From 5eaf7fdfe7c831d3aa24428a6e8d4509ac160db6 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Tue, 18 Feb 2014 12:23:19 +0100 Subject: [PATCH] ARM: davinci: use explicit 'select' for DA850_EVM The DAVINCI_DA850_EVM board uses an unusual method to enable the GPIO_PCA953X and KEYBOARD_GPIO_POLLED symbols, which leads to the dependencies on these symbols being ignored. As GPIO_PCA953X actually requires I2C, that can lead to build failures when I2C is disabled. This patch removes the duplicate symbol definitions and instead enables them from the davinci_all_defconfig file. A different question whether we actually want to automatically enable them at all or rather put them into defconfig, but that should be a separate patch. Signed-off-by: Arnd Bergmann Acked-by: Sekhar Nori Cc: Kevin Hilman Cc: davinci-linux-open-source@linux.davincidsp.com Acked-by: Sekhar Nori diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig index fff4eb6..16bdfab 100644 --- a/arch/arm/configs/davinci_all_defconfig +++ b/arch/arm/configs/davinci_all_defconfig @@ -218,3 +218,5 @@ CONFIG_DEBUG_ERRORS=y # CONFIG_CRYPTO_ANSI_CPRNG is not set # CONFIG_CRYPTO_HW is not set CONFIG_CRC_T10DIF=m +CONFIG_GPIO_PCA953X=y +CONFIG_KEYBOARD_GPIO_POLLED=y diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig index 3b98e34..db18ef8 100644 --- a/arch/arm/mach-davinci/Kconfig +++ b/arch/arm/mach-davinci/Kconfig @@ -209,11 +209,6 @@ config DA850_WL12XX Say Y if you want to use a wl1271 expansion card connected to the AM18x EVM. -config GPIO_PCA953X - default MACH_DAVINCI_DA850_EVM - -config KEYBOARD_GPIO_POLLED - default MACH_DAVINCI_DA850_EVM config MACH_MITYOMAPL138 bool "Critical Link MityDSP-L138/MityARM-1808 SoM"