From patchwork Tue May 20 11:59:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mel Gorman X-Patchwork-Id: 4209141 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 20E2D9F23C for ; Tue, 20 May 2014 12:13:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 34DCB2035D for ; Tue, 20 May 2014 12:13:07 +0000 (UTC) Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0105820353 for ; Tue, 20 May 2014 12:13:05 +0000 (UTC) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id s4KCC6UQ002215; Tue, 20 May 2014 07:12:06 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s4KCC5Lk016105; Tue, 20 May 2014 07:12:05 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Tue, 20 May 2014 07:12:05 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s4KCC4VZ025680; Tue, 20 May 2014 07:12:04 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 8D5E180627; Tue, 20 May 2014 07:12:04 -0500 (CDT) X-Original-To: Davinci-linux-open-source@linux.davincidsp.com Delivered-To: Davinci-linux-open-source@linux.davincidsp.com Received: from dlelxv84.itg.ti.com (dlelxv84.itg.ti.com [172.17.0.246]) by linux.omap.com (Postfix) with ESMTP id CFB4A80626 for ; Tue, 20 May 2014 06:59:57 -0500 (CDT) Received: from red.ext.ti.com (red.ext.ti.com [192.94.93.37]) by dlelxv84.itg.ti.com (8.14.3/8.13.8) with ESMTP id s4KBxvQ6022828 for ; Tue, 20 May 2014 06:59:57 -0500 Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by red.ext.ti.com (8.13.7/8.13.7) with ESMTP id s4KBxtEe003393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 May 2014 06:59:57 -0500 Received: from [216.82.250.99:33286] by server-5.bemta-12.messagelabs.com id 20/09-18132-AB34B735; Tue, 20 May 2014 11:59:54 +0000 X-Env-Sender: mgorman@suse.de X-Msg-Ref: server-8.tower-126.messagelabs.com!1400587192!7954970!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=1.4 required=7.0 tests=BODY_RANDOM_LONG, SUBJ_HAS_UNIQ_ID X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 20702 invoked from network); 20 May 2014 11:59:54 -0000 Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by server-8.tower-126.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 20 May 2014 11:59:54 -0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DD324ABE8; Tue, 20 May 2014 11:59:51 +0000 (UTC) Date: Tue, 20 May 2014 12:59:48 +0100 From: Mel Gorman To: Prabhakar Lad Subject: Re: davinci boot failures in next-20140519 Message-ID: <20140520115948.GM23991@suse.de> References: <7hoaytvckm.fsf@paris.lan> <537B0EA7.8070608@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Mailman-Approved-At: Tue, 20 May 2014 07:12:02 -0500 CC: DaVinci list X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, May 20, 2014 at 02:46:47PM +0530, Prabhakar Lad wrote: > Hi Sekhar, > > On Tue, May 20, 2014 at 1:43 PM, Sekhar Nori wrote: > > On Tuesday 20 May 2014 12:49 PM, Prabhakar Lad wrote: > >> Hi, > >> > >> On Tue, May 20, 2014 at 12:08 AM, Kevin Hilman wrote: > >>> As found by my automated boot tester[1], dm365 EVM and da850 EVM started > >>> failing boot tests in today's linux-next. > >>> > >>> I haven't had the time to bisect, but it appears to be related to some > >>> devres failures in the EMAC driver. Full boot log below for the > >>> da850evm (the dm365 fault looks the same.) > >>> > >> I too hit this issue, this was introduced with commit id: > >> e194312854edc22a2faf1931b3c0608fe20cb969 (drivers: net: > >> davinci_cpdma: Convert kzalloc() to devm_kzalloc().) > >> Reverting this patch fixes it. > >> From the outset patch looks good, not sure why exactly it is failing. > > > > Following patch seems to help. I will post it for review after some more > > analysis. > > > I am not sure if you hit the following issue later fixing above one, > I see following issue on DA850 evm, > > git bisect points me to > commit id: 975c3a671f11279441006a29a19f55ccc15fb320 > ( mm: non-atomically mark page accessed during page cache allocation > where possible) > > Unable to handle kernel paging request at virtual address 30e03501 > pgd = c68cc000 > [30e03501] *pgd=00000000 > Internal error: Oops: 1 [#1] PREEMPT ARM > Modules linked in: > CPU: 0 PID: 1015 Comm: network.sh Not tainted 3.15.0-rc5-00323-g975c3a6 #9 > task: c70c4e00 ti: c73d0000 task.ti: c73d0000 > PC is at init_page_accessed+0xc/0x24 > LR is at shmem_write_begin+0x54/0x60 > pc : [] lr : [] psr: 20000013 What line does this address correspond to according to addr2line? It's not a NULL pointer exception obviously because the data address does not match up and there is a check for NULL before calling init_page_accessed. The obvious guess would be that this is due to an uninitialised page pointer on the stack and shmem_getpage_gfp() returning before it gets initialised. Could you try this please? diff --git a/mm/filemap.c b/mm/filemap.c index 2a7b9d1..0691481 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2459,7 +2459,7 @@ ssize_t generic_perform_write(struct file *file, flags |= AOP_FLAG_UNINTERRUPTIBLE; do { - struct page *page; + struct page *page = NULL; unsigned long offset; /* Offset into pagecache page */ unsigned long bytes; /* Bytes to write to page */ size_t copied; /* Bytes copied from user */