From patchwork Mon Jul 13 19:47:34 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Troy Kisky X-Patchwork-Id: 35433 Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n6DJo8Dr020694 for ; Mon, 13 Jul 2009 19:50:08 GMT Received: from dlep36.itg.ti.com ([157.170.170.91]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id n6DJltgP030366; Mon, 13 Jul 2009 14:48:00 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by dlep36.itg.ti.com (8.13.8/8.13.8) with ESMTP id n6DJltdF005073; Mon, 13 Jul 2009 14:47:55 -0500 (CDT) Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 735DD80627; Mon, 13 Jul 2009 14:47:54 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp52.itg.ti.com (dflp52.itg.ti.com [128.247.22.96]) by linux.omap.com (Postfix) with ESMTP id A2EF480626 for ; Mon, 13 Jul 2009 14:47:52 -0500 (CDT) Received: from medina.ext.ti.com (localhost [127.0.0.1]) by dflp52.itg.ti.com (8.13.7/8.13.7) with ESMTP id n6DJlqVG020858 for ; Mon, 13 Jul 2009 14:47:52 -0500 (CDT) Received: from mail120-dub-R.bigfish.com (mail-dub.bigfish.com [213.199.154.10]) by medina.ext.ti.com (8.13.7/8.13.7) with ESMTP id n6DJlksL013588 for ; Mon, 13 Jul 2009 14:47:52 -0500 Received: from mail120-dub (localhost.localdomain [127.0.0.1]) by mail120-dub-R.bigfish.com (Postfix) with ESMTP id CC13F3680C7 for ; Mon, 13 Jul 2009 19:47:45 +0000 (UTC) X-SpamScore: -26 X-BigFish: vps-26(zz1432R98dN936eM1805Mzz1202hzzz2dh6bh61h) X-Spam-TCS-SCL: 0:0 X-MS-Exchange-Organization-Antispam-Report: OrigIP: 64.26.60.137; Service: EHS Received: by mail120-dub (MessageSwitch) id 1247514464489739_17988; Mon, 13 Jul 2009 19:47:44 +0000 (UCT) Received: from smtpauth03.csee.onr.siteprotect.com (smtpauth03.csee.onr.siteprotect.com [64.26.60.137]) by mail120-dub.bigfish.com (Postfix) with ESMTP id 19A43C78052 for ; Mon, 13 Jul 2009 19:47:44 +0000 (UTC) Received: from [192.168.0.251] (unknown [67.42.45.38]) (Authenticated sender: troy.kisky@boundarydevices.com) by smtpauth03.csee.onr.siteprotect.com (Postfix) with ESMTP id 3B4271038008; Mon, 13 Jul 2009 14:47:42 -0500 (CDT) Message-ID: <4A5B8F56.8070902@boundarydevices.com> Date: Mon, 13 Jul 2009 12:47:34 -0700 From: Troy Kisky User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: Russell King - ARM Linux References: <7A436F7769CA33409C6B44B358BFFF0C011E51262E@dlee02.ent.ti.com> <4A579AE6.2030606@boundarydevices.com> <20090711123846.GA23978@n2100.arm.linux.org.uk> In-Reply-To: <20090711123846.GA23978@n2100.arm.linux.org.uk> X-Enigmail-Version: 0.95.7 Cc: "davinci-linux-open-source@linux.davincidsp.com" , Mark Brown , "linux-arm-kernel@lists.arm.linux.org.uk" , "Medisetty, Naresh" Subject: Re: [PATCH 07/26] davinci: dm646x: Adds McASP clock X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.4 Precedence: list List-Id: davinci-linux-open-source.linux.davincidsp.com List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: davinci-linux-open-source-bounces@linux.davincidsp.com Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com Russell King - ARM Linux wrote: > On Fri, Jul 10, 2009 at 12:47:50PM -0700, Troy Kisky wrote: >> Mani, Arun wrote: >>> Hi, >>> I am trying the latest 2.6.31 rc2 branch. I am trying to make the Audio work. >>> I found that the I2S clock is set to NULL. Because of this I am getting a NODEV error. >>> If I commented the check, I was able to map the I2S to the AIC33X. but I am not getting any sound. >> You need a clock, so don't comment out the check, rather give it one. ie. >> >> +static struct snd_platform_data snd_data = { >> + .clk_name = "asp0", >> +}; >> + > > This is broken from the clk API perspective. clock "names" must not > be passed via platform data. If you want to do that kind of thing you > might as well give up with the clk API and stop abusing it. > Then this patch needs further review. I added Chaithrika to the CC. commit 2a0232a115e81a4687d7ae07d5e1f2719a67f8a8 Author: Chaithrika U S Date: Fri Jun 5 06:28:08 2009 -0400 davinci: ASoC: Add the platform devices for ASP 1) Registers the platform devices for ASP on dm355, dm644x and dm646x so that the machine driver can probe to get ASP related platform data. 2) Move towards definition of the asp clocks using physical name(for dm355 and dm644x) 3) Add platform data to board specific files. Signed-off-by: Naresh Medisetty Signed-off-by: Chaithrika U S Signed-off-by: Kevin Hilman diff --git a/arch/arm/mach-davinci/board-dm355-evm.c b/arch/arm/mach-davinci/board-dm355-evm.c index 5ac2f56..78a9604 100644 --- a/arch/arm/mach-davinci/board-dm355-evm.c +++ b/arch/arm/mach-davinci/board-dm355-evm.c @@ -118,6 +118,10 @@ static struct davinci_i2c_platform_data i2c_pdata = { .bus_delay = 0 /* usec */, }; +static struct snd_platform_data dm355_evm_snd_data = { + .clk_name = "asp1", +}; + static int dm355evm_mmc_gpios = -EINVAL; static void dm355evm_mmcsd_gpios(unsigned gpio) @@ -280,6 +284,9 @@ static __init void dm355_evm_init(void) dm355_init_spi0(BIT(0), dm355_evm_spi_info, ARRAY_SIZE(dm355_evm_spi_info)); + + /* DM335 EVM uses ASP1; line-out is a stereo mini-jack */ + dm355_init_asp1(ASP1_TX_EVT_EN | ASP1_RX_EVT_EN, &dm355_evm_snd_data); }