From patchwork Wed Mar 17 13:55:27 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Murali Karicheri X-Patchwork-Id: 86341 Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o2HEBEwf009263 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Mar 2010 14:11:50 GMT Received: from dlep34.itg.ti.com ([157.170.170.115]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id o2HDtVqK008483 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Mar 2010 08:55:31 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by dlep34.itg.ti.com (8.13.7/8.13.7) with ESMTP id o2HDtVOG011054; Wed, 17 Mar 2010 08:55:31 -0500 (CDT) Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 587D780627; Wed, 17 Mar 2010 07:55:30 -0600 (CST) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dlep26.itg.ti.com (dlep26.itg.ti.com [157.170.170.121]) by linux.omap.com (Postfix) with ESMTP id D4BCE80626 for ; Wed, 17 Mar 2010 07:55:28 -0600 (CST) Received: from dsbe71.ent.ti.com (localhost [127.0.0.1]) by dlep26.itg.ti.com (8.13.8/8.13.8) with ESMTP id o2HDtSNp019172; Wed, 17 Mar 2010 08:55:28 -0500 (CDT) Received: from dlee06.ent.ti.com ([157.170.170.11]) by dsbe71.ent.ti.com ([156.117.232.23]) with mapi; Wed, 17 Mar 2010 08:55:28 -0500 From: "Karicheri, Muralidharan" To: Raffaele Recalcati , davinci-linux-open-source Date: Wed, 17 Mar 2010 08:55:27 -0500 Subject: RE: kernel BUG in VPFE with DM365 Thread-Topic: kernel BUG in VPFE with DM365 Thread-Index: AcrFzqYlbzQPxzT4Ryil15KsFC0DtAACTzmw Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: davinci-linux-open-source-bounces@linux.davincidsp.com Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com X-Greylist: Sender succeeded STARTTLS authentication, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Wed, 17 Mar 2010 14:11:50 +0000 (UTC) diff --git a/drivers/media/video/davinci/isif.c b/drivers/media/video/davinci/is index 29c29c6..4412a43 100644 --- a/drivers/media/video/davinci/isif.c +++ b/drivers/media/video/davinci/isif.c @@ -861,6 +861,36 @@ static void isif_setfbaddr(unsigned long addr)         regw((addr >> 5) & 0x0ffff, CADL);  }   +/* Parameter operations */ +/* TODO from dm355 ccdc_set_params */ +static int isif_set_params(void __user *params) +{ +#if 0 +       struct ccdc_config_params_raw ccdc_raw_params; +       int x; + +       /* only raw module parameters can be set through the IOCTL */ +       if (ccdc_cfg.if_type != VPFE_RAW_BAYER) +               return -EINVAL; + +       x = copy_from_user(&ccdc_raw_params, params, sizeof(ccdc_raw_params)); +       if (x) { +               dev_dbg(ccdc_cfg.dev, "ccdc_set_params: error in copying ccdc" +                       "params, %d\n", x); +               return -EFAULT; +       } + +       if (!validate_ccdc_param(&ccdc_raw_params)) { +               memcpy(&ccdc_cfg.bayer.config_params, +                       &ccdc_raw_params, +                       sizeof(ccdc_raw_params)); +               return 0; +       } +       return -EINVAL; +#else +       return 0; +#endif +}  static int isif_set_hw_if_params(struct vpfe_hw_if_param *params)  {         isif_cfg.if_type = params->if_type; @@ -1015,6 +1045,7 @@ static struct ccdc_hw_device isif_hw_dev = {                 .enable = isif_enable,                 .enable_out_to_sdram = isif_enable_output_to_sdram,                 .set_hw_if_params = isif_set_hw_if_params, +               .set_params = isif_set_params,                 .configure = isif_configure,                 .set_buftype = isif_set_buftype,                 .get_buftype = isif_get_buftype,