diff mbox

[media] vpif_display: fix error return code in vpif_probe()

Message ID CAPgLHd_iDfVzq2S_uSh1tBVpQdFa4oyMpWGovDDNCYsh0bLJog@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Yongjun May 13, 2013, 5:57 a.m. UTC 
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Fix to return -ENODEV in the subdevice register error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/media/platform/davinci/vpif_display.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Prabhakar May 13, 2013, 6:04 a.m. UTC | #1 
Hi Wei,

Thanks for the patch.

On Mon, May 13, 2013 at 11:27 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -ENODEV in the subdevice register error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Regards,
--Prabhakar Lad
Prabhakar May 23, 2013, 9:25 a.m. UTC | #2 
Hi Hans,

On Mon, May 13, 2013 at 11:34 AM, Prabhakar Lad
<prabhakar.csengg@gmail.com> wrote:
> Hi Wei,
>
> Thanks for the patch.
>
> On Mon, May 13, 2013 at 11:27 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Fix to return -ENODEV in the subdevice register error handling
>> case instead of 0, as done elsewhere in this function.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>
Can you pick this patch ? and a similar looking patch for vpif display.

Regards,
--Prabhakar Lad
Hans Verkuil (hansverk) May 23, 2013, 9:26 a.m. UTC | #3 
On Thu 23 May 2013 11:25:25 Prabhakar Lad wrote:
> Hi Hans,
> 
> On Mon, May 13, 2013 at 11:34 AM, Prabhakar Lad
> <prabhakar.csengg@gmail.com> wrote:
> > Hi Wei,
> >
> > Thanks for the patch.
> >
> > On Mon, May 13, 2013 at 11:27 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> >> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >>
> >> Fix to return -ENODEV in the subdevice register error handling
> >> case instead of 0, as done elsewhere in this function.
> >>
> >> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> >
> Can you pick this patch ? and a similar looking patch for vpif display.

It's already in my queue.

	Hans
diff mbox

Patch

diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/davinci/vpif_display.c
index 1b3fb5c..50b2f39 100644
--- a/drivers/media/platform/davinci/vpif_display.c
+++ b/drivers/media/platform/davinci/vpif_display.c
@@ -1813,6 +1813,7 @@  static __init int vpif_probe(struct platform_device *pdev)
 						NULL);
 		if (!vpif_obj.sd[i]) {
 			vpif_err("Error registering v4l2 subdevice\n");
+			err = -ENODEV;
 			goto probe_subdev_out;
 		}