From patchwork Mon May 13 05:57:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2556431 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by patchwork2.kernel.org (Postfix) with ESMTP id 04DB0DF2E5 for ; Mon, 13 May 2013 05:58:59 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id r4D5vVDL007144; Mon, 13 May 2013 00:57:31 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r4D5vVUc002961; Mon, 13 May 2013 00:57:31 -0500 Received: from dlelxv23.itg.ti.com (172.17.1.198) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.2.342.3; Mon, 13 May 2013 00:57:30 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlelxv23.itg.ti.com (8.13.8/8.13.8) with ESMTP id r4D5vUsa014170; Mon, 13 May 2013 00:57:30 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id CFF1D80627; Mon, 13 May 2013 00:57:28 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp51.itg.ti.com (dflp51.itg.ti.com [128.247.22.94]) by linux.omap.com (Postfix) with ESMTP id 25A4A80626 for ; Mon, 13 May 2013 00:57:27 -0500 (CDT) Received: from medina.ext.ti.com (medina.ext.ti.com [192.91.81.31]) by dflp51.itg.ti.com (8.13.7/8.13.8) with ESMTP id r4D5vQK6029252 for ; Mon, 13 May 2013 00:57:26 -0500 (CDT) Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by medina.ext.ti.com (8.13.7/8.13.7) with ESMTP id r4D5vQIR028832 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 May 2013 00:57:26 -0500 Received: from [216.82.253.147:7428] by server-3.bemta-7.messagelabs.com id 1E/65-29734-6C080915; Mon, 13 May 2013 05:57:26 +0000 X-Env-Sender: weiyj.lk@gmail.com X-Msg-Ref: server-15.tower-165.messagelabs.com!1368424644!10875673!1 X-Originating-IP: [209.85.214.51] X-SpamReason: No, hits=0.3 required=7.0 tests=ML_RADAR_SPEW_LINKS_14, RCVD_BY_IP,spamassassin: X-StarScan-Received: X-StarScan-Version: 6.9.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 1213 invoked from network); 13 May 2013 05:57:25 -0000 Received: from mail-bk0-f51.google.com (HELO mail-bk0-f51.google.com) (209.85.214.51) by server-15.tower-165.messagelabs.com with RC4-SHA encrypted SMTP; 13 May 2013 05:57:25 -0000 Received: by mail-bk0-f51.google.com with SMTP id ji2so2269978bkc.10 for ; Sun, 12 May 2013 22:57:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=DiPfBwN3bn91j3XVU6LvQ1M92q/wpkNztEQ8yYoSjSc=; b=tomrO/Xpi0nnUqwoPl+dJxcgwWMVJSapngrCnuG3RmG4Y+wz+4iwfE4qzs2hrEF7SF eW3yhyuvTehnUx0+Gh0lbxHHOP87AxTNY1jWpk8Jsm+tiIlpkVXuPs53e1kPrAlXWdvF mL8NEWQpOzFZWJTh6WaCknqbEjXIaMar355wWPWO54UTHFbZ+7RU6/QTIJn8jYqPOgER ZbLEcA+P1d44/Izq5SD39HV8/fK0fFrnvjz7GbASPcTTg+tjoInU5a4CN+TKvUBR01o1 H7cCnUhRPFdHCpjQ4upVEwZ9LF45osZk4wHWCSIqAFoOwxK/dbenr08KRsR9fOsK5tVd fyhA== MIME-Version: 1.0 X-Received: by 10.204.57.13 with SMTP id a13mr5212444bkh.63.1368424643584; Sun, 12 May 2013 22:57:23 -0700 (PDT) Received: by 10.204.199.129 with HTTP; Sun, 12 May 2013 22:57:23 -0700 (PDT) Date: Mon, 13 May 2013 13:57:23 +0800 Message-ID: Subject: [PATCH] [media] vpif_display: fix error return code in vpif_probe() From: Wei Yongjun To: , CC: , , X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com From: Wei Yongjun Fix to return -ENODEV in the subdevice register error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Acked-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/davinci/vpif_display.c index 1b3fb5c..50b2f39 100644 --- a/drivers/media/platform/davinci/vpif_display.c +++ b/drivers/media/platform/davinci/vpif_display.c @@ -1813,6 +1813,7 @@ static __init int vpif_probe(struct platform_device *pdev) NULL); if (!vpif_obj.sd[i]) { vpif_err("Error registering v4l2 subdevice\n"); + err = -ENODEV; goto probe_subdev_out; }