From patchwork Wed Oct 10 09:59:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kumar, Anil" X-Patchwork-Id: 1572561 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by patchwork2.kernel.org (Postfix) with ESMTP id 125CADFB34 for ; Wed, 10 Oct 2012 10:01:56 +0000 (UTC) Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id q9A9xtGA007880; Wed, 10 Oct 2012 04:59:55 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id q9A9xt3k032386; Wed, 10 Oct 2012 04:59:55 -0500 Received: from dlelxv24.itg.ti.com (172.17.1.199) by dfle73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.1.323.3; Wed, 10 Oct 2012 04:59:55 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlelxv24.itg.ti.com (8.13.8/8.13.8) with ESMTP id q9A9xtSh029150; Wed, 10 Oct 2012 04:59:55 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 688A980627; Wed, 10 Oct 2012 04:59:55 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dbdp20.itg.ti.com (dbdp20.itg.ti.com [172.24.170.38]) by linux.omap.com (Postfix) with ESMTP id 468F580626 for ; Wed, 10 Oct 2012 04:59:53 -0500 (CDT) Received: from DBDE70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id q9A9xm6q024825; Wed, 10 Oct 2012 15:29:48 +0530 (IST) Received: from DBDE01.ent.ti.com ([fe80::d5df:c4b5:9919:4e10]) by DBDE70.ent.ti.com ([fe80::2141:513f:409:315a%21]) with mapi id 14.01.0323.003; Wed, 10 Oct 2012 15:29:48 +0530 From: "Kumar, Anil" To: Daniel Mack Subject: RE: [PATCH 0/2] Convert davinci ASoC to genalloc SRAM Thread-Topic: [PATCH 0/2] Convert davinci ASoC to genalloc SRAM Thread-Index: AQHNpqffLG9GQkGCZEGqausiKS4GCZeyGaAg//+n7YCAAIm4AA== Date: Wed, 10 Oct 2012 09:59:48 +0000 Message-ID: References: <1349345745-10584-1-git-send-email-mporter@ti.com> <50751E0F.3010906@gmail.com> In-Reply-To: <50751E0F.3010906@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] MIME-Version: 1.0 CC: Linux DaVinci Kernel List , "Porter, Matt" , Alsa Devel List , Mark Brown , Linux Kernel Mailing List X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com On Wed, Oct 10, 2012 at 12:34:47, Daniel Mack wrote: > On 10.10.2012 08:54, Kumar, Anil wrote: > > On Thu, Oct 04, 2012 at 15:45:43, Porter, Matt wrote: > >> This series converts davinci ASoC to use genalloc and enables > >> that support on DA850. It applies on top of the uio_pruss/genalloc > >> series [1] which allows DaVinci to provide a gen_pool via pdata > >> for driver use. > >> > >> I've tested this on the AM180x EVM. Note that prior to this, > >> the SRAM paths in the driver were completely unused. I've only > >> enabled ping-pong buffering on the platform I can test as it's > >> best to allow those with DM644x and similar platforms to set the > >> playback/capture sram size to something that's known to work > >> for them. > >> > >> [1] http://www.spinics.net/lists/arm-kernel/msg198854.html > > > > Tested on DA850 EVM after applying patches from [1] above. > > Tested on Linux-torvalds 3.6-rc6 master branch. > > Tested ASoC module (aplay & arecord for various frequencies) > > > > Acked-by: Kumar, Anil > > As you're on it, could you also quickly merge this branch > > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git > topic/davinci > > And see if my recent patches for more McASP flexibility cause any > trouble on your hardware? > > > Daniel > > I have merged it with 3.6-rc6 and I have got error at compile time. I have fixed this locally with the following patch [1]. Kindly confirm if the patch is correct? With that Tested on DA850 EVM Tested on Linux-torvalds 3.6-rc6 master branch merged + [1] Tested ASoC module (aplay & arecord for various frequencies) Tested-By: Kumar, Anil [1] git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/davinci. [2] patch Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 09da4e5..9c02a45 100644 --- a/include/linux/dmaengine.h +++ b/include/linux/dmaengine.h @@ -591,7 +591,7 @@ struct dma_device { struct dma_async_tx_descriptor *(*device_prep_dma_cyclic)( struct dma_chan *chan, dma_addr_t buf_addr, size_t buf_len, size_t period_len, enum dma_transfer_direction direction, - unsigned long flags, void *context); + void *context); struct dma_async_tx_descriptor *(*device_prep_interleaved_dma)( struct dma_chan *chan, struct dma_interleaved_template *xt, unsigned long flags); @@ -656,7 +656,7 @@ static inline struct dma_async_tx_descriptor *dmaengine_prep_dma_cyclic( size_t period_len, enum dma_transfer_direction dir) { return chan->device->device_prep_dma_cyclic(chan, buf_addr, buf_len, - period_len, dir, flags, NULL); + period_len, dir, NULL); } _______________________________________________