| Message ID | f02f2bda26f87fff2bb9e958baa12672cae7e362.1305723716.git.bengardiner@nanometrics.ca (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Wed, May 18, 2011 at 09:27:46AM -0400, Ben Gardiner wrote: > The davinci-mcasp driver will copy the platform data specified sram sizes and > eventq's. > > Set the event queues and sram sizes for da850. 8K SRAM buffers are selected > because it is the minimum that resulted in the same period size when testing > 48KHz S16_LE stereo. Event queues 0 and 1 are assigned to match those > specified by Troy Kisky in his introduction of ping-pong buffers for dm644x. > > Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca> Davinci folks, are you OK with this?
Hi Mark, On Fri, May 20, 2011 at 02:44:06, Mark Brown wrote: > On Wed, May 18, 2011 at 09:27:46AM -0400, Ben Gardiner wrote: > > The davinci-mcasp driver will copy the platform data specified sram sizes and > > eventq's. > > > > Set the event queues and sram sizes for da850. 8K SRAM buffers are selected > > because it is the minimum that resulted in the same period size when testing > > 48KHz S16_LE stereo. Event queues 0 and 1 are assigned to match those > > specified by Troy Kisky in his introduction of ping-pong buffers for dm644x. > > > > Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca> > > Davinci folks, are you OK with this? No, please don't merge this just yet. As Ben mentioned in his cover letter, the default SRAM pool on DA850 is not suitable for Audio transfers. This patch depends on SRAM not being available for audio usage in spite of the platform asking for it. This is liable to break. The SRAM allocation on DaVinci and OMAP is under a bit of flux and once that is sorted out, this patch should be safe to merge. So, this probably needs to wait for 2.6.41. Thanks, Sekhar
diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c index a7b41bf..2ee1a6f 100644 --- a/arch/arm/mach-davinci/board-da850-evm.c +++ b/arch/arm/mach-davinci/board-da850-evm.c @@ -722,10 +722,13 @@ static struct snd_platform_data da850_evm_snd_data = { .num_serializer = ARRAY_SIZE(da850_iis_serializer_direction), .tdm_slots = 2, .serial_dir = da850_iis_serializer_direction, - .asp_chan_q = EVENTQ_1, + .asp_chan_q = EVENTQ_0, + .ram_chan_q = EVENTQ_1, .version = MCASP_VERSION_2, .txnumevt = 1, .rxnumevt = 1, + .sram_size_playback = SZ_8K, + .sram_size_capture = SZ_8K, }; static const short da850_evm_mcasp_pins[] __initconst = {
The davinci-mcasp driver will copy the platform data specified sram sizes and eventq's. Set the event queues and sram sizes for da850. 8K SRAM buffers are selected because it is the minimum that resulted in the same period size when testing 48KHz S16_LE stereo. Event queues 0 and 1 are assigned to match those specified by Troy Kisky in his introduction of ping-pong buffers for dm644x. Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca> --- arch/arm/mach-davinci/board-da850-evm.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)