| Message ID | 20210128084455.2237256-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| Headers | show |
| Series | dmaengine: rcar-dmac: Add support for R-Car V3U | expand |
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Thursday, January 28, 2021 5:45 PM > > Hi Vinod, > > This patch series adds support for the Direct Memory Access Controller > variant in the Renesas R-Car V3U (R8A779A0) SoC, to both DT bindings and > driver. > > Changes compared to v2: > - Add Reviewed-by, Tested-by, > - Place iterator after container being iterated, > - Stop passing index to rcar_dmac_chan_probe(). > > Changes compared to v1: > - Add Reviewed-by, > - Put the full loop control of for_each_rcar_dmac_chan() on a single > line, to improve readability, > - Use two separate named regions instead of array, > - Drop rcar_dmac_of_data.chan_reg_block, check for > !rcar_dmac_of_data.chan_offset_base instead, > - Precalculate chan_base in rcar_dmac_probe(). > > This has been tested on the Renesas Falcon board, using external SPI > loopback (spi-loopback-test) on MSIOF1 and MSIOF2. Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Also, I tested on H3 Salvator-XS and the Falcon board with dmatest driver. So, Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda
On 28-01-21, 09:44, Geert Uytterhoeven wrote: > Hi Vinod, > > This patch series adds support for the Direct Memory Access Controller > variant in the Renesas R-Car V3U (R8A779A0) SoC, to both DT bindings and > driver. Applied all, thanks
Hi Vinod, This patch series adds support for the Direct Memory Access Controller variant in the Renesas R-Car V3U (R8A779A0) SoC, to both DT bindings and driver. Changes compared to v2: - Add Reviewed-by, Tested-by, - Place iterator after container being iterated, - Stop passing index to rcar_dmac_chan_probe(). Changes compared to v1: - Add Reviewed-by, - Put the full loop control of for_each_rcar_dmac_chan() on a single line, to improve readability, - Use two separate named regions instead of array, - Drop rcar_dmac_of_data.chan_reg_block, check for !rcar_dmac_of_data.chan_offset_base instead, - Precalculate chan_base in rcar_dmac_probe(). This has been tested on the Renesas Falcon board, using external SPI loopback (spi-loopback-test) on MSIOF1 and MSIOF2. Thanks! Geert Uytterhoeven (4): dt-bindings: renesas,rcar-dmac: Add r8a779a0 support dmaengine: rcar-dmac: Add for_each_rcar_dmac_chan() helper dmaengine: rcar-dmac: Add helpers for clearing DMA channel status dmaengine: rcar-dmac: Add support for R-Car V3U .../bindings/dma/renesas,rcar-dmac.yaml | 76 +++++++----- drivers/dma/sh/rcar-dmac.c | 112 ++++++++++++------ 2 files changed, 126 insertions(+), 62 deletions(-)