| Message ID | 20231105093415.3704633-6-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | dmaengine: Convert to platform remove callback returning void (part II) | expand |
On Sun, 05 Nov 2023 10:34:16 +0100, Uwe Kleine-König wrote: > after > https://lore.kernel.org/all/20230919133207.1400430-1-u.kleine-koenig@pengutronix.de/ > this series also converts the drivers that have a bogus error path in > their remove function. These patches don't fix the underlying problem > but still improve a bit, as the error message gets more detailed. > > I don't know enough about the dma subsystem to propose a better fix, so > the drivers are only converted to use .remove_new() to not be in the way > for my quest to make struct platform_driver::remove return void. The > quest's goal is to prevent such bogus error paths to occur in new code. > See commit 5c5a7680e67b ("platform: Provide a remove callback that > returns no value") for an extended explanation. > > [...] Applied, thanks! [1/4] dmaengine: milbeaut-hdmac: Convert to platform remove callback returning void commit: 0fdd1c4ea99e188dfa8ab7bafbe4004cc72dca30 [2/4] dmaengine: milbeaut-xdmac: Convert to platform remove callback returning void commit: 47ee210011ddb8b366c7dcf9c1a9c3818573df29 [3/4] dmaengine: uniphier-mdmac: Convert to platform remove callback returning void commit: 5d4304a8d5646c268d73383fbc179db53f85b921 [4/4] dmaengine: uniphier-xdmac: Convert to platform remove callback returning void commit: ead0e402e50d1101939e4af67891d5b2fa9678b3 Best regards,
Hello, after https://lore.kernel.org/all/20230919133207.1400430-1-u.kleine-koenig@pengutronix.de/ this series also converts the drivers that have a bogus error path in their remove function. These patches don't fix the underlying problem but still improve a bit, as the error message gets more detailed. I don't know enough about the dma subsystem to propose a better fix, so the drivers are only converted to use .remove_new() to not be in the way for my quest to make struct platform_driver::remove return void. The quest's goal is to prevent such bogus error paths to occur in new code. See commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") for an extended explanation. Best regards Uwe Uwe Kleine-König (4): dmaengine: milbeaut-hdmac: Convert to platform remove callback returning void dmaengine: milbeaut-xdmac: Convert to platform remove callback returning void dmaengine: uniphier-mdmac: Convert to platform remove callback returning void dmaengine: uniphier-xdmac: Convert to platform remove callback returning void drivers/dma/milbeaut-hdmac.c | 17 +++++++++++------ drivers/dma/milbeaut-xdmac.c | 17 +++++++++++------ drivers/dma/uniphier-mdmac.c | 17 +++++++++++------ drivers/dma/uniphier-xdmac.c | 17 +++++++++++------ 4 files changed, 44 insertions(+), 24 deletions(-) base-commit: e27090b1413ff236ca1aec26d6b022149115de2c