[v8,0/2] Add support for Loongson1 APB DMA

Message

Keguang Zhang via B4 Relay June 7, 2024, 12:12 p.m. UTC

Add the driver and dt-binding document for Loongson1 APB DMA.

Changes in v8:
- Change 'interrupts' property to an items list
- Link to v7: https://lore.kernel.org/r/[e-mail]

Changes in v7:
- Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen)
- Update the title and description part accordingly
- Rename the file to loongson,ls1b-apbdma.yaml
- Add a compatible string for LS1A
- Delete minItems of 'interrupts'
- Change patterns of 'interrupt-names' to const
- Rename the file to loongson1-apb-dma.c to keep the consistency
- Update Kconfig and Makefile accordingly
- Link to v6: https://lore.kernel.org/r/[e-mail]

Changes in v6:
- Change the compatible to the fallback
- Implement .device_prep_dma_cyclic for Loongson1 sound driver,
- as well as .device_pause and .device_resume.
- Set the limitation LS1X_DMA_MAX_DESC and put all descriptors
- into one page to save memory
- Move dma_pool_zalloc() into ls1x_dma_alloc_desc()
- Drop dma_slave_config structure
- Use .remove_new instead of .remove
- Use KBUILD_MODNAME for the driver name
- Improve the debug information
- Some minor fixes

Changes in v5:
- Add the dt-binding document
- Add DT support
- Use DT information instead of platform data
- Use chan_id of struct dma_chan instead of own id
- Use of_dma_xlate_by_chan_id() instead of ls1x_dma_filter()
- Update the author information to my official name

Changes in v4:
- Use dma_slave_map to find the proper channel.
- Explicitly call devm_request_irq() and tasklet_kill().
- Fix namespace issue.
- Some minor fixes and cleanups.

Changes in v3:
- Rename ls1x_dma_filter_fn to ls1x_dma_filter.

Changes in v2:
- Change the config from 'DMA_LOONGSON1' to 'LOONGSON1_DMA',
- and rearrange it in alphabetical order in Kconfig and Makefile.
- Fix comment style.

---
Keguang Zhang (2):
      dt-bindings: dma: Add Loongson-1 APB DMA
      dmaengine: Loongson1: Add Loongson-1 APB DMA driver

 .../bindings/dma/loongson,ls1b-apbdma.yaml         |  67 +++
 drivers/dma/Kconfig                                |   9 +
 drivers/dma/Makefile                               |   1 +
 drivers/dma/loongson1-apb-dma.c                    | 665 +++++++++++++++++++++
 4 files changed, 742 insertions(+)
---
base-commit: d35b2284e966c0bef3e2182a5c5ea02177dd32e4
change-id: 20231120-loongson1-dma-163afe5708b9

Best regards,

Comments

Vinod Koul June 11, 2024, 6:31 p.m. UTC | #1

On 07-06-24, 20:12, Keguang Zhang via B4 Relay wrote:
> Add the driver and dt-binding document for Loongson1 APB DMA.

I get build warnings with this. Please build with W=1 and C=1 and fix
all the errors and warnings reported and update

Keguang Zhang June 13, 2024, 10:04 a.m. UTC | #2

On Wed, Jun 12, 2024 at 2:31 AM Vinod Koul <[e-mail]> wrote:
>
> On 07-06-24, 20:12, Keguang Zhang via B4 Relay wrote:
> > Add the driver and dt-binding document for Loongson1 APB DMA.
>
> I get build warnings with this. Please build with W=1 and C=1 and fix
> all the errors and warnings reported and update
>
Sorry, will fix this ASAP.

> --
> ~Vinod

Vinod Koul Aug. 29, 2024, 5:30 p.m. UTC | #3

On Fri, 07 Jun 2024 20:12:22 +0800, Keguang Zhang wrote:
> Add the driver and dt-binding document for Loongson1 APB DMA.
> 
> Changes in v8:
> - Change 'interrupts' property to an items list
> - Link to v7: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v7:
> - Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen)
> - Update the title and description part accordingly
> - Rename the file to loongson,ls1b-apbdma.yaml
> - Add a compatible string for LS1A
> - Delete minItems of 'interrupts'
> - Change patterns of 'interrupt-names' to const
> - Rename the file to loongson1-apb-dma.c to keep the consistency
> - Update Kconfig and Makefile accordingly
> - Link to v6: https://lore.kernel.org/r/[e-mail]
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: dma: Add Loongson-1 APB DMA
      commit: 7ea270bb93e4ce165bb4f834c29c05e9815b6ca8
[2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver
      commit: e06c432312148ddb550ec55b004e32671657ea23

Best regards,