| Message ID | cover.1548230893.git.lukas@wunner.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Raspberry Pi DMA fixes + cleanups | expand |
> Lukas Wunner <lukas@wunner.de> hat am 23. Januar 2019 um 09:26 geschrieben: > > > Two fixes and four cleanups for the Raspberry Pi DMA driver, v2. > > Changes since v1: > > * Patch [1/6]: Rework the patch to fix a race condition which could > still occur with v1, and no longer check for idleness of a channel > using the ACTIVE flag in the CS register (which is unreliable), > but check for a zero control block address instead. > > * Patch [2/6]: If outstanding writes fail to complete on abort of a > transaction, print an error message and document a possible cause > in a code comment. (Stefan Wahren) > > * Patch [5/6] and [6/6]: Split patch to remove dead code in two and > rephrase commit subject to be less generic. (Stefan Wahren, Vinod Koul) > > Thanks, > > Lukas > > > Lukas Wunner (6): > dmaengine: bcm2835: Fix interrupt race on RT > dmaengine: bcm2835: Fix abort of transactions > dmaengine: bcm2835: Return void from abort of transactions > dmaengine: bcm2835: Enforce control block alignment > dmaengine: bcm2835: Drop gratuitous list deletion > dmaengine: bcm2835: Drop outdated comment on supported transactions > The whole series is: Tested-by: Stefan Wahren <stefan.wahren@i2se.com> Thanks
Acked-by: Florian Kauer <florian.kauer@koalo.de> Am Mi., 23. Jan. 2019 um 17:10 Uhr schrieb Stefan Wahren <stefan.wahren@i2se.com>: > > > > Lukas Wunner <lukas@wunner.de> hat am 23. Januar 2019 um 09:26 geschrieben: > > > > > > Two fixes and four cleanups for the Raspberry Pi DMA driver, v2. > > > > Changes since v1: > > > > * Patch [1/6]: Rework the patch to fix a race condition which could > > still occur with v1, and no longer check for idleness of a channel > > using the ACTIVE flag in the CS register (which is unreliable), > > but check for a zero control block address instead. > > > > * Patch [2/6]: If outstanding writes fail to complete on abort of a > > transaction, print an error message and document a possible cause > > in a code comment. (Stefan Wahren) > > > > * Patch [5/6] and [6/6]: Split patch to remove dead code in two and > > rephrase commit subject to be less generic. (Stefan Wahren, Vinod Koul) > > > > Thanks, > > > > Lukas > > > > > > Lukas Wunner (6): > > dmaengine: bcm2835: Fix interrupt race on RT > > dmaengine: bcm2835: Fix abort of transactions > > dmaengine: bcm2835: Return void from abort of transactions > > dmaengine: bcm2835: Enforce control block alignment > > dmaengine: bcm2835: Drop gratuitous list deletion > > dmaengine: bcm2835: Drop outdated comment on supported transactions > > > > The whole series is: > > Tested-by: Stefan Wahren <stefan.wahren@i2se.com> > > Thanks
On 23-01-19, 09:26, Lukas Wunner wrote: > Two fixes and four cleanups for the Raspberry Pi DMA driver, v2. Applied all, thanks > > Changes since v1: > > * Patch [1/6]: Rework the patch to fix a race condition which could > still occur with v1, and no longer check for idleness of a channel > using the ACTIVE flag in the CS register (which is unreliable), > but check for a zero control block address instead. > > * Patch [2/6]: If outstanding writes fail to complete on abort of a > transaction, print an error message and document a possible cause > in a code comment. (Stefan Wahren) > > * Patch [5/6] and [6/6]: Split patch to remove dead code in two and > rephrase commit subject to be less generic. (Stefan Wahren, Vinod Koul) > > Thanks, > > Lukas > > > Lukas Wunner (6): > dmaengine: bcm2835: Fix interrupt race on RT > dmaengine: bcm2835: Fix abort of transactions > dmaengine: bcm2835: Return void from abort of transactions > dmaengine: bcm2835: Enforce control block alignment > dmaengine: bcm2835: Drop gratuitous list deletion > dmaengine: bcm2835: Drop outdated comment on supported transactions > > drivers/dma/bcm2835-dma.c | 92 +++++++++++++-------------------------- > 1 file changed, 31 insertions(+), 61 deletions(-) > > -- > 2.20.1