From patchwork Thu Nov 6 01:10:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 5238601 Return-Path: X-Original-To: patchwork-dmaengine@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B8193C11AC for ; Thu, 6 Nov 2014 01:09:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DE85B20172 for ; Thu, 6 Nov 2014 01:09:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB9282015E for ; Thu, 6 Nov 2014 01:09:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750974AbaKFBJi (ORCPT ); Wed, 5 Nov 2014 20:09:38 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:18151 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbaKFBJh (ORCPT ); Wed, 5 Nov 2014 20:09:37 -0500 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NEL004U6F7ZFH60@mailout3.samsung.com> for dmaengine@vger.kernel.org; Thu, 06 Nov 2014 10:09:35 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 1C.85.18167.F4ACA545; Thu, 06 Nov 2014 10:09:35 +0900 (KST) X-AuditID: cbfee690-f79ab6d0000046f7-0f-545aca4fac7d Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 6A.7C.09430.F4ACA545; Thu, 06 Nov 2014 10:09:35 +0900 (KST) Received: from DOJG1HAN03 ([10.89.38.123]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NEL003XVF7ZM300@mmp2.samsung.com>; Thu, 06 Nov 2014 10:09:35 +0900 (KST) From: Jingoo Han To: 'Vinod Koul' Cc: dmaengine@vger.kernel.org, "'Williams, Dan J'" , 'Shawn Guo' , 'Jingoo Han' Subject: [PATCH] dma: imx-sdma: remove incorrect __init annotation from sdma_init() Date: Thu, 06 Nov 2014 10:10:09 +0900 Message-id: <001201cff95e$68e0f8d0$3aa2ea70$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac/5Xmion671VKHrRbKZ2nrsV6HP3A== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsVy+t8zfV3/U1EhBvN2a1tMn3qB0WL11L+s FpcXXmK1eLpuCbPFy779LA6sHov3vGTyuHNtD5tH35ZVjB6fN8kFsERx2aSk5mSWpRbp2yVw ZfTc2cxU8Jej4tT0G6wNjIfYuxg5OSQETCT6d/9ghLDFJC7cW8/WxcjFISSwjFGi9+ZvZpii P73fGSES04ESLfdZIJxfjBJHzv4Ga2cTUJP48uUw0FgODhEBdYml12VAaphBGmYuO8YGUiMs ECrx8u9fJhCbRUBV4sWpF2BxXgFbiUc/LzNB2IISPybfYwGxmQW0JNbvPM4EYctLbF7zlhlk vgTQ/Ed/dUHCIgJ6Eq9vP2GEKBGR2PfiHdihEgK72CUmn+5lhdglIPFt8iEWiF5ZiU0HoB6T lDi44gbLBEaxWUg2z0KyeRaSzbOQrFjAyLKKUTS1ILmgOCm9yESvODG3uDQvXS85P3cTIyTi JuxgvHfA+hCjAAejEg/vjqNRIUKsiWXFlbmHGE2BLprILCWanA+M67ySeENjMyMLUxNTYyNz SzMlcd7XUj+DhQTSE0tSs1NTC1KL4otKc1KLDzEycXBKNTAu4TR4peLdIbeqxPrjgm0piTZs odMTeI/q2At5GEW9NjHz4P1o/Uxa1izkffGCqNePBSb81opLNEw6e9rg7cJMPY7gva/txWxW 1wbn3imdX7P6n+uytmeX5BpWJxSUF00/q1Cjy/onmWfDQmdOy2y5bxs67yf+YDq4JPr1u9aU R4K+WU2/s5VYijMSDbWYi4oTAWYUVKCzAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFIsWRmVeSWpSXmKPExsVy+t9jQV3/U1EhBkf2q1tMn3qB0WL11L+s FpcXXmK1eLpuCbPFy779LA6sHov3vGTyuHNtD5tH35ZVjB6fN8kFsEQ1MNpkpCampBYppOYl 56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAC1WUihLzCkFCgUkFhcr6dth mhAa4qZrAdMYoesbEgTXY2SABhLWMWb03NnMVPCXo+LU9BusDYyH2LsYOTkkBEwk/vR+Z4Sw xSQu3FvP1sXIxSEkMJ1RorflPguE84tR4sjZ32BVbAJqEl++HAbq5uAQEVCXWHpdBqSGGaRh 5rJjbCA1wgKhEi///mUCsVkEVCVenHoBFucVsJV49PMyE4QtKPFj8j0WEJtZQEti/c7jTBC2 vMTmNW+ZQeZLAM1/9FcXJCwioCfx+vYTRogSEYl9L94xTmAUmIVk0iwkk2YhmTQLScsCRpZV jKKpBckFxUnpuUZ6xYm5xaV56XrJ+bmbGMHx/Ex6B+OqBotDjAIcjEo8vDuORoUIsSaWFVfm HmKU4GBWEuF9cxwoxJuSWFmVWpQfX1Sak1p8iNEU6NGJzFKiyfnAVJNXEm9obGJmZGlkZmFk Ym6uJM57sNU6UEggPbEkNTs1tSC1CKaPiYNTqoFxOcvM2SsnLH7WKJtS5iSWZN1rzN1p1NW3 Jupu8965VhqP9L/wqSmp2zjwzt0udvmQlc/3oNvtB55s3c729q3ZntPyu8w0uHIjjAOTTkW8 Ydx/9mRN6s0uv2t+lZGn+P5cXCDmI2p6Pa922ao/93I2X5u1ZXbOtfqS6qMbxPOe+8alPH/E 8UtLiaU4I9FQi7moOBEA/eBVP/0CAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When platform_driver_probe() is not used, sdma_probe() can be called by bind/unbind via sysfs. In addition, sdma_init() can be called by sdma_probe(). Thus, __init annotation should be removed from sdma_init(), Also, this patch fixes section mismatch warning. WARNING: drivers/dma/built-in.o(.text+0xd6e4): Section mismatch in reference from the function sdma_probe() to the function .init.text:sdma_init() The function sdma_probe() references the function __init sdma_init(). This is often because sdma_probe lacks a __init annotation or the annotation of sdma_init is wrong. Signed-off-by: Jingoo Han --- drivers/dma/imx-sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 88afc48..99d8833 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1346,7 +1346,7 @@ static int sdma_get_firmware(struct sdma_engine *sdma, return ret; } -static int __init sdma_init(struct sdma_engine *sdma) +static int sdma_init(struct sdma_engine *sdma) { int i, ret; dma_addr_t ccb_phys;