From patchwork Wed Nov 6 15:50:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Jiang X-Patchwork-Id: 3148111 X-Patchwork-Delegate: dan.j.williams@gmail.com Return-Path: X-Original-To: patchwork-dmaengine@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 05AA59F407 for ; Wed, 6 Nov 2013 15:50:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B07BE2053B for ; Wed, 6 Nov 2013 15:50:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7DD6920304 for ; Wed, 6 Nov 2013 15:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754443Ab3KFPu3 (ORCPT ); Wed, 6 Nov 2013 10:50:29 -0500 Received: from mga14.intel.com ([143.182.124.37]:43010 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754348Ab3KFPu2 (ORCPT ); Wed, 6 Nov 2013 10:50:28 -0500 Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga102.ch.intel.com with ESMTP; 06 Nov 2013 07:50:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,535,1378882800"; d="scan'208";a="317774575" Received: from djiang5-linux2.ch.intel.com ([10.2.105.54]) by AZSMGA002.ch.intel.com with ESMTP; 06 Nov 2013 07:50:28 -0800 From: dave.jiang@intel.com To: dmaengine@vger.kernel.org Cc: dan.j.williams@intel.com, Dave Jiang Subject: [PATCH] ioatdma: Fix bug in selftest after removal of DMA_MEMSET. Date: Wed, 6 Nov 2013 08:50:09 -0700 Message-Id: <1383753009-30022-1-git-send-email-dave.jiang@intel.com> X-Mailer: git-send-email 1.8.3.1 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dave Jiang Commit 48a9db4 removed the memset op in the xor selftest for ioatdma. The issue is that with the removal of that op, it never replaced the memset with a CPU memset. The memory being operated on is expected to be zeroes but was not. This is causing the xor selftest to fail. Signed-off-by: Dave Jiang --- drivers/dma/ioat/dma_v3.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c index d8ececa..fa32d9f 100644 --- a/drivers/dma/ioat/dma_v3.c +++ b/drivers/dma/ioat/dma_v3.c @@ -1545,6 +1545,8 @@ static int ioat_xor_val_self_test(struct ioatdma_device *device) goto free_resources; } + memset(page_address(dest), 0, PAGE_SIZE); + /* test for non-zero parity sum */ op = IOAT_OP_XOR_VAL;