| Message ID | 1393093008-19667-2-git-send-email-shc_work@mail.ru (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Vinod Koul |
| Headers | show |
On Sat, 2014-02-22 at 22:16 +0400, Alexander Shiyan wrote: Detailed description? > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > --- > drivers/dma/imx-dma.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c > index 7ef16e8..bc78142 100644 > --- a/drivers/dma/imx-dma.c > +++ b/drivers/dma/imx-dma.c > @@ -1101,7 +1101,7 @@ static int __init imxdma_probe(struct platform_device *pdev) > ret = devm_request_irq(&pdev->dev, irq, > dma_irq_handler, 0, "DMA", imxdma); > if (ret) { > - dev_warn(imxdma->dev, "Can't register IRQ for DMA\n"); > + dev_err(imxdma->dev, "Can't register IRQ for DMA\n"); > goto err; > } > > @@ -1114,7 +1114,7 @@ static int __init imxdma_probe(struct platform_device *pdev) > ret = devm_request_irq(&pdev->dev, irq_err, > imxdma_err_handler, 0, "DMAERR", imxdma); > if (ret) { > - dev_warn(imxdma->dev, "Can't register ERRIRQ for DMA\n"); > + dev_err(imxdma->dev, "Can't register ERRIRQ for DMA\n"); > goto err; > } > } > @@ -1151,9 +1151,8 @@ static int __init imxdma_probe(struct platform_device *pdev) > dma_irq_handler, 0, > imxdmac->name, imxdma); > if (ret) { > - dev_warn(imxdma->dev, "Can't register IRQ %d " > - "for DMA channel %d\n", > - irq + i, i); > + dev_err(imxdma->dev, "Can't register IRQ %d " > + "for DMA channel %d\n", irq + i, i); You may live string concatenated, since it's better to grep, like dev_warn(imxdma->dev, "Can't register IRQ %d for DMA channel %d\n", irq + i, i); > goto err; > } > init_timer(&imxdmac->watchdog); -- Andy Shevchenko <andriy.shevchenko@intel.com> Intel Finland Oy --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c index 7ef16e8..bc78142 100644 --- a/drivers/dma/imx-dma.c +++ b/drivers/dma/imx-dma.c @@ -1101,7 +1101,7 @@ static int __init imxdma_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq, dma_irq_handler, 0, "DMA", imxdma); if (ret) { - dev_warn(imxdma->dev, "Can't register IRQ for DMA\n"); + dev_err(imxdma->dev, "Can't register IRQ for DMA\n"); goto err; } @@ -1114,7 +1114,7 @@ static int __init imxdma_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq_err, imxdma_err_handler, 0, "DMAERR", imxdma); if (ret) { - dev_warn(imxdma->dev, "Can't register ERRIRQ for DMA\n"); + dev_err(imxdma->dev, "Can't register ERRIRQ for DMA\n"); goto err; } } @@ -1151,9 +1151,8 @@ static int __init imxdma_probe(struct platform_device *pdev) dma_irq_handler, 0, imxdmac->name, imxdma); if (ret) { - dev_warn(imxdma->dev, "Can't register IRQ %d " - "for DMA channel %d\n", - irq + i, i); + dev_err(imxdma->dev, "Can't register IRQ %d " + "for DMA channel %d\n", irq + i, i); goto err; } init_timer(&imxdmac->watchdog);
Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- drivers/dma/imx-dma.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)