| Message ID | 1394702320-21743-11-git-send-email-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Vinod Koul |
| Headers | show |
On Thu, 2014-03-13 at 11:18 +0200, Peter Ujfalusi wrote: > Do not print the paRAM information when verbose debugging is not asked and > also reduce the number of lines printed in edma_prep_dma_cyclic() > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- > drivers/dma/edma.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c > index e4f4a0cef58c..e2aa42b8342f 100644 > --- a/drivers/dma/edma.c > +++ b/drivers/dma/edma.c > @@ -141,7 +141,7 @@ static void edma_execute(struct edma_chan *echan) > for (i = 0; i < nslots; i++) { > j = i + edesc->processed; > edma_write_slot(echan->slot[i], &edesc->pset[j]); > - dev_dbg(echan->vchan.chan.device->dev, > + dev_vdbg(echan->vchan.chan.device->dev, > "\n pset[%d]:\n" > " chnum\t%d\n" > " slot\t%d\n" I believe you may move this code to separate function and reuse it later. Moreover %d is not good specifier for unsigned types, maybe %u? > @@ -554,9 +554,8 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic( > edesc->cyclic = 1; > edesc->pset_nr = nslots; > > - dev_dbg(dev, "%s: nslots=%d\n", __func__, nslots); > - dev_dbg(dev, "%s: period_len=%d\n", __func__, period_len); > - dev_dbg(dev, "%s: buf_len=%d\n", __func__, buf_len); > + dev_dbg(dev, "%s: channel=%d nslots=%d period_len=%d buf_len=%d\n", > + __func__, echan->ch_num, nslots, period_len, buf_len); Consider to use proper specifiers for size_t types, namely %zd. > > for (i = 0; i < nslots; i++) { > /* Allocate a PaRAM slot, if needed */ > @@ -590,8 +589,8 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic( > else > src_addr += period_len; > > - dev_dbg(dev, "%s: Configure period %d of buf:\n", __func__, i); > - dev_dbg(dev, > + dev_vdbg(dev, "%s: Configure period %d of buf:\n", __func__, i); > + dev_vdbg(dev, See the first comment. > "\n pset[%d]:\n" > " chnum\t%d\n" > " slot\t%d\n" -- Andy Shevchenko <andriy.shevchenko@intel.com> Intel Finland Oy --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
On 03/13/2014 02:53 PM, Shevchenko, Andriy wrote: > On Thu, 2014-03-13 at 11:18 +0200, Peter Ujfalusi wrote: >> Do not print the paRAM information when verbose debugging is not asked and >> also reduce the number of lines printed in edma_prep_dma_cyclic() >> >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> >> --- >> drivers/dma/edma.c | 11 +++++------ >> 1 file changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c >> index e4f4a0cef58c..e2aa42b8342f 100644 >> --- a/drivers/dma/edma.c >> +++ b/drivers/dma/edma.c >> @@ -141,7 +141,7 @@ static void edma_execute(struct edma_chan *echan) >> for (i = 0; i < nslots; i++) { >> j = i + edesc->processed; >> edma_write_slot(echan->slot[i], &edesc->pset[j]); >> - dev_dbg(echan->vchan.chan.device->dev, >> + dev_vdbg(echan->vchan.chan.device->dev, >> "\n pset[%d]:\n" >> " chnum\t%d\n" >> " slot\t%d\n" > > I believe you may move this code to separate function and reuse it > later. As the per patch description, I only changed the debug level in this patch. > Moreover %d is not good specifier for unsigned types, maybe %u? You are right for unsigned type %u is the correct. This is why we have %d since j, echan->ch_num and echan->slot[i] are integer. > >> @@ -554,9 +554,8 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic( >> edesc->cyclic = 1; >> edesc->pset_nr = nslots; >> >> - dev_dbg(dev, "%s: nslots=%d\n", __func__, nslots); >> - dev_dbg(dev, "%s: period_len=%d\n", __func__, period_len); >> - dev_dbg(dev, "%s: buf_len=%d\n", __func__, buf_len); >> + dev_dbg(dev, "%s: channel=%d nslots=%d period_len=%d buf_len=%d\n", >> + __func__, echan->ch_num, nslots, period_len, buf_len); > > Consider to use proper specifiers for size_t types, namely %zd. I just collapsed the three line of dev_dbg into one and have not really checked the formats. For size_t the correct format should be %zu. I'll fix this up for the next version. >> >> for (i = 0; i < nslots; i++) { >> /* Allocate a PaRAM slot, if needed */ >> @@ -590,8 +589,8 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic( >> else >> src_addr += period_len; >> >> - dev_dbg(dev, "%s: Configure period %d of buf:\n", __func__, i); >> - dev_dbg(dev, >> + dev_vdbg(dev, "%s: Configure period %d of buf:\n", __func__, i); >> + dev_vdbg(dev, > > See the first comment. As the per patch description, I only changed the debug level in this patch. This can be done as a separate patch later IMO as part of a bigger debug cleanup.
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index e4f4a0cef58c..e2aa42b8342f 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c @@ -141,7 +141,7 @@ static void edma_execute(struct edma_chan *echan) for (i = 0; i < nslots; i++) { j = i + edesc->processed; edma_write_slot(echan->slot[i], &edesc->pset[j]); - dev_dbg(echan->vchan.chan.device->dev, + dev_vdbg(echan->vchan.chan.device->dev, "\n pset[%d]:\n" " chnum\t%d\n" " slot\t%d\n" @@ -554,9 +554,8 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic( edesc->cyclic = 1; edesc->pset_nr = nslots; - dev_dbg(dev, "%s: nslots=%d\n", __func__, nslots); - dev_dbg(dev, "%s: period_len=%d\n", __func__, period_len); - dev_dbg(dev, "%s: buf_len=%d\n", __func__, buf_len); + dev_dbg(dev, "%s: channel=%d nslots=%d period_len=%d buf_len=%d\n", + __func__, echan->ch_num, nslots, period_len, buf_len); for (i = 0; i < nslots; i++) { /* Allocate a PaRAM slot, if needed */ @@ -590,8 +589,8 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic( else src_addr += period_len; - dev_dbg(dev, "%s: Configure period %d of buf:\n", __func__, i); - dev_dbg(dev, + dev_vdbg(dev, "%s: Configure period %d of buf:\n", __func__, i); + dev_vdbg(dev, "\n pset[%d]:\n" " chnum\t%d\n" " slot\t%d\n"
Do not print the paRAM information when verbose debugging is not asked and also reduce the number of lines printed in edma_prep_dma_cyclic() Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- drivers/dma/edma.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)