diff mbox

[4/6] dma: mmp_pdma: Fix physical channel memory allocation size

Message ID 1397574817-15559-5-git-send-email-laurent.pinchart@ideasonboard.com (mailing list archive)
State Accepted
Commit 593d9c2e10bc
Delegated to: Vinod Koul
Headers show

Commit Message

Laurent Pinchart April 15, 2014, 3:13 p.m. UTC 
Use sizeof(*var) instead of sizeof(type) when calling devm_k*alloc().
This avoids using the wrong type as was done to allocate the physical
channels array.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/dma/mmp_pdma.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Vinod Koul May 2, 2014, 3:52 p.m. UTC | #1 
On Tue, Apr 15, 2014 at 05:13:35PM +0200, Laurent Pinchart wrote:
> Use sizeof(*var) instead of sizeof(type) when calling devm_k*alloc().
> This avoids using the wrong type as was done to allocate the physical
> channels array.
>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
index 643f225..7ed7850 100644
--- a/drivers/dma/mmp_pdma.c
+++ b/drivers/dma/mmp_pdma.c
@@ -858,8 +858,7 @@  static int mmp_pdma_chan_init(struct mmp_pdma_device *pdev, int idx, int irq)
 	struct mmp_pdma_chan *chan;
 	int ret;
 
-	chan = devm_kzalloc(pdev->dev, sizeof(struct mmp_pdma_chan),
-			    GFP_KERNEL);
+	chan = devm_kzalloc(pdev->dev, sizeof(*chan), GFP_KERNEL);
 	if (chan == NULL)
 		return -ENOMEM;
 
@@ -946,8 +945,7 @@  static int mmp_pdma_probe(struct platform_device *op)
 			irq_num++;
 	}
 
-	pdev->phy = devm_kcalloc(pdev->dev,
-				 dma_channels, sizeof(struct mmp_pdma_chan),
+	pdev->phy = devm_kcalloc(pdev->dev, dma_channels, sizeof(*pdev->phy),
 				 GFP_KERNEL);
 	if (pdev->phy == NULL)
 		return -ENOMEM;