| Message ID | 1401682704-32204-1-git-send-email-vinod.koul@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a68765430772 |
| Delegated to: | Vinod Koul |
| Headers | show |
Hi Vinod, Thank you for the patch. On Monday 02 June 2014 09:48:22 Vinod Koul wrote: > kbuild test robot reports that shdma_prep_dma_cyclic should be static, since > symbol is not declared, quick check revails that is the case > > >> drivers/dma/sh/shdma-base.c:660:32: sparse: symbol > >> 'shdma_prep_dma_cyclic' > >> was not declared. Should it be static? > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Vinod Koul <vinod.koul@intel.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/dma/sh/shdma-base.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c > index 974794c..66b4a35 100644 > --- a/drivers/dma/sh/shdma-base.c > +++ b/drivers/dma/sh/shdma-base.c > @@ -657,7 +657,7 @@ static struct dma_async_tx_descriptor > *shdma_prep_slave_sg( direction, flags, false); > } > > -struct dma_async_tx_descriptor *shdma_prep_dma_cyclic( > +static struct dma_async_tx_descriptor *shdma_prep_dma_cyclic( > struct dma_chan *chan, dma_addr_t buf_addr, size_t buf_len, > size_t period_len, enum dma_transfer_direction direction, > unsigned long flags, void *context)
diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c index 974794c..66b4a35 100644 --- a/drivers/dma/sh/shdma-base.c +++ b/drivers/dma/sh/shdma-base.c @@ -657,7 +657,7 @@ static struct dma_async_tx_descriptor *shdma_prep_slave_sg( direction, flags, false); } -struct dma_async_tx_descriptor *shdma_prep_dma_cyclic( +static struct dma_async_tx_descriptor *shdma_prep_dma_cyclic( struct dma_chan *chan, dma_addr_t buf_addr, size_t buf_len, size_t period_len, enum dma_transfer_direction direction, unsigned long flags, void *context)