| Message ID | 1406801558-13126-1-git-send-email-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 04d537d95e2f |
| Delegated to: | Vinod Koul |
| Headers | show |
On Thu, Jul 31, 2014 at 01:12:37PM +0300, Peter Ujfalusi wrote: > In case of edma_alloc_slot() failure during probe we should return the error > unchanged to make debugging easier. Applied both Thanks
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 69f1f5250120..2953de0f53f3 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c @@ -1048,7 +1048,7 @@ static int edma_probe(struct platform_device *pdev) ecc->dummy_slot = edma_alloc_slot(ecc->ctlr, EDMA_SLOT_ANY); if (ecc->dummy_slot < 0) { dev_err(&pdev->dev, "Can't allocate PaRAM dummy slot\n"); - return -EIO; + return ecc->dummy_slot; } dma_cap_zero(ecc->dma_slave.cap_mask);
In case of edma_alloc_slot() failure during probe we should return the error unchanged to make debugging easier. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- drivers/dma/edma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)