diff mbox

dma: imx-sdma: Remove spurious __init annotation on sdma_probe()

Message ID 1409136953-26595-1-git-send-email-broonie@kernel.org (mailing list archive)
State Accepted
Headers show

Commit Message

Mark Brown Aug. 27, 2014, 10:55 a.m. UTC 
From: Mark Brown <broonie@linaro.org>

We can't annotate probe functions as __init since binding can occur at
any time, not just during kernel init.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 drivers/dma/imx-sdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shawn Guo Aug. 28, 2014, 3:23 a.m. UTC | #1 
On Wed, Aug 27, 2014 at 11:55:53AM +0100, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
> 
> We can't annotate probe functions as __init since binding can occur at
> any time, not just during kernel init.
> 
> Signed-off-by: Mark Brown <broonie@linaro.org>

Acked-by: Shawn Guo <shawn.guo@linaro.org>
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vinod Koul Aug. 28, 2014, 7:14 a.m. UTC | #2 
On Wed, Aug 27, 2014 at 11:55:53AM +0100, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
> 
> We can't annotate probe functions as __init since binding can occur at
> any time, not just during kernel init.

Applied, thanks
diff mbox

Patch

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index c615e88c118a..52ce1d21154c 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1448,7 +1448,7 @@  static struct dma_chan *sdma_xlate(struct of_phandle_args *dma_spec,
 	return dma_request_channel(mask, sdma_filter_fn, &data);
 }
 
-static int __init sdma_probe(struct platform_device *pdev)
+static int sdma_probe(struct platform_device *pdev)
 {
 	const struct of_device_id *of_id =
 			of_match_device(sdma_dt_ids, &pdev->dev);