From patchwork Tue Dec 23 17:52:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Mc Guire X-Patchwork-Id: 5534831 Return-Path: X-Original-To: patchwork-dmaengine@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DD4939F1CD for ; Tue, 23 Dec 2014 19:01:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E32AA2012D for ; Tue, 23 Dec 2014 19:01:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18B15200FF for ; Tue, 23 Dec 2014 19:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750725AbaLWTBs (ORCPT ); Tue, 23 Dec 2014 14:01:48 -0500 Received: from www.osadl.org ([62.245.132.105]:34188 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbaLWTBs (ORCPT ); Tue, 23 Dec 2014 14:01:48 -0500 X-Greylist: delayed 3685 seconds by postgrey-1.27 at vger.kernel.org; Tue, 23 Dec 2014 14:01:47 EST Received: from debian.hofr.at (92-243-35-153.adsl.nanet.at [92.243.35.153] (may be forged)) by www.osadl.org (8.13.8/8.13.8/OSADL-2007092901) with ESMTP id sBNI06HK002625; Tue, 23 Dec 2014 19:00:06 +0100 From: Nicholas Mc Guire To: Dan Williams Cc: Vinod Koul , Prarit Bhargava , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH] incorrect use of init_completion fixup Date: Tue, 23 Dec 2014 18:52:31 +0100 Message-Id: <1419357151-22889-1-git-send-email-der.herr@hofr.at> X-Mailer: git-send-email 1.7.10.4 X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The successive init_completion calls should be reinit_completion here. patch is against 3.18.0 linux-next Signed-off-by: Nicholas Mc Guire --- drivers/dma/ioat/dma_v3.c | 4 +- 1 files changed, 2 insertions(+), 2 deletions(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c index 32eae38..3dbcc42 100644 --- a/drivers/dma/ioat/dma_v3.c +++ b/drivers/dma/ioat/dma_v3.c @@ -1353,7 +1353,7 @@ static int ioat_xor_val_self_test(struct ioatdma_device *device) } async_tx_ack(tx); - init_completion(&cmp); + reinit_completion(&cmp); tx->callback = ioat3_dma_test_callback; tx->callback_param = &cmp; cookie = tx->tx_submit(tx); @@ -1405,7 +1405,7 @@ static int ioat_xor_val_self_test(struct ioatdma_device *device) } async_tx_ack(tx); - init_completion(&cmp); + reinit_completion(&cmp); tx->callback = ioat3_dma_test_callback; tx->callback_param = &cmp; cookie = tx->tx_submit(tx);