| Message ID | 1420608537-12296-4-git-send-email-mchitale@apm.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Wednesday 07 January 2015 10:58:56 Mayuresh Chitale wrote: > > + xpdma0: dma0@1f2b0154 { > + status = "disabled"; > + compatible = "apm,xgene-pciedma"; > + reg = < 0x0 0x1f2b0154 0x0 0xc > + 0x0 0x1f2b0058 0x0 0x8>; > + interrupts = <0x0 0xc6 0x4>; > + }; > + > + xpdma1: dma1@1f2c0154 { > + status = "disabled"; > + compatible = "apm,xgene-pciedma"; > + reg = < 0x0 0x1f2c0154 0x0 0xc > + 0x0 0x1f2c0058 0x0 0x8>; > + interrupts = <0x0 0xcc 0x4>; > + }; > + > Something's wrong here: you have the same addresses for all the nodes but use different names. Please change the names to all say 'dma' and set the correct addresses. Arnd -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Arnd, Actually the addresses are different. For e.g port 0 base address is 1F2B0000 and port 1 base address is 1F2C0000 and so on. Thanks, Mayuresh. On Wed, Jan 7, 2015 at 2:07 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Wednesday 07 January 2015 10:58:56 Mayuresh Chitale wrote: >> >> + xpdma0: dma0@1f2b0154 { >> + status = "disabled"; >> + compatible = "apm,xgene-pciedma"; >> + reg = < 0x0 0x1f2b0154 0x0 0xc >> + 0x0 0x1f2b0058 0x0 0x8>; >> + interrupts = <0x0 0xc6 0x4>; >> + }; >> + >> + xpdma1: dma1@1f2c0154 { >> + status = "disabled"; >> + compatible = "apm,xgene-pciedma"; >> + reg = < 0x0 0x1f2c0154 0x0 0xc >> + 0x0 0x1f2c0058 0x0 0x8>; >> + interrupts = <0x0 0xcc 0x4>; >> + }; >> + >> > > Something's wrong here: you have the same addresses for > all the nodes but use different names. Please change the names > to all say 'dma' and set the correct addresses. > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 07 January 2015 16:15:54 Mayuresh Chitale wrote: > Hi Arnd, > > Actually the addresses are different. For e.g port 0 base address is > 1F2B0000 and port 1 base address is 1F2C0000 and so on. > Ah, I see now. Just change the name to 'dma' then. Arnd -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi index f1ad9c2..2993d1e 100644 --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi @@ -469,6 +469,46 @@ clocks = <&pcie4clk 0>; }; + xpdma0: dma0@1f2b0154 { + status = "disabled"; + compatible = "apm,xgene-pciedma"; + reg = < 0x0 0x1f2b0154 0x0 0xc + 0x0 0x1f2b0058 0x0 0x8>; + interrupts = <0x0 0xc6 0x4>; + }; + + xpdma1: dma1@1f2c0154 { + status = "disabled"; + compatible = "apm,xgene-pciedma"; + reg = < 0x0 0x1f2c0154 0x0 0xc + 0x0 0x1f2c0058 0x0 0x8>; + interrupts = <0x0 0xcc 0x4>; + }; + + xpdma2: dma2@1f2d0154 { + status = "disabled"; + compatible = "apm,xgene-pciedma"; + reg = < 0x0 0x1f2d0154 0x0 0xc + 0x0 0x1f2d0058 0x0 0x8>; + interrupts = <0x0 0xd2 0x4>; + }; + + xpdma3: dma3@1f500154 { + status = "disabled"; + compatible = "apm,xgene-pciedma"; + reg = < 0x0 0x1f500154 0x0 0xc + 0x0 0x1f500058 0x0 0x8>; + interrupts = <0x0 0xd8 0x4>; + }; + + xpdma4: dma4@1f510154 { + status = "disabled"; + compatible = "apm,xgene-pciedma"; + reg = < 0x0 0x1f510154 0x0 0xc + 0x0 0x1f510058 0x0 0x8>; + interrupts = <0x0 0xde 0x4>; + }; + serial0: serial@1c020000 { status = "disabled"; device_type = "serial";