| Message ID | 1424904842-27902-1-git-send-email-balbi@ti.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Wed, Feb 25, 2015 at 04:54:02PM -0600, Felipe Balbi wrote: > Without those we will see a kernel WARN() > when loading musb on am335x devices. > > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > drivers/dma/cppi41.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c > index 512cb8e2805e..4e9cc8e8100c 100644 > --- a/drivers/dma/cppi41.c > +++ b/drivers/dma/cppi41.c > @@ -926,6 +926,7 @@ static int cppi41_dma_probe(struct platform_device *pdev) > cdd->ddev.device_issue_pending = cppi41_dma_issue_pending; > cdd->ddev.device_prep_slave_sg = cppi41_dma_prep_slave_sg; > cdd->ddev.device_terminate_all = cppi41_stop_chan; > + cdd->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV); > cdd->ddev.dev = dev; > INIT_LIST_HEAD(&cdd->ddev.channels); > cpp41_dma_info.dma_cap = cdd->ddev.cap_mask; Along with this please set src/dstn_addr_widths and residue_granularity please
On Wed, Mar 04, 2015 at 06:13:23PM +0530, Vinod Koul wrote: > On Wed, Feb 25, 2015 at 04:54:02PM -0600, Felipe Balbi wrote: > > Without those we will see a kernel WARN() > > when loading musb on am335x devices. > > > > Signed-off-by: Felipe Balbi <balbi@ti.com> > > --- > > drivers/dma/cppi41.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c > > index 512cb8e2805e..4e9cc8e8100c 100644 > > --- a/drivers/dma/cppi41.c > > +++ b/drivers/dma/cppi41.c > > @@ -926,6 +926,7 @@ static int cppi41_dma_probe(struct platform_device *pdev) > > cdd->ddev.device_issue_pending = cppi41_dma_issue_pending; > > cdd->ddev.device_prep_slave_sg = cppi41_dma_prep_slave_sg; > > cdd->ddev.device_terminate_all = cppi41_stop_chan; > > + cdd->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV); > > cdd->ddev.dev = dev; > > INIT_LIST_HEAD(&cdd->ddev.channels); > > cpp41_dma_info.dma_cap = cdd->ddev.cap_mask; > Along with this please set src/dstn_addr_widths and residue_granularity > please will do.
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c index 512cb8e2805e..4e9cc8e8100c 100644 --- a/drivers/dma/cppi41.c +++ b/drivers/dma/cppi41.c @@ -926,6 +926,7 @@ static int cppi41_dma_probe(struct platform_device *pdev) cdd->ddev.device_issue_pending = cppi41_dma_issue_pending; cdd->ddev.device_prep_slave_sg = cppi41_dma_prep_slave_sg; cdd->ddev.device_terminate_all = cppi41_stop_chan; + cdd->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV); cdd->ddev.dev = dev; INIT_LIST_HEAD(&cdd->ddev.channels); cpp41_dma_info.dma_cap = cdd->ddev.cap_mask;
Without those we will see a kernel WARN() when loading musb on am335x devices. Signed-off-by: Felipe Balbi <balbi@ti.com> --- drivers/dma/cppi41.c | 1 + 1 file changed, 1 insertion(+)